On 9 May 2017 at 15:00, Rene Engelhard wrote:
| tag 862132 + patch
| thanks
| 
| Hi,
| 
| On Tue, May 09, 2017 at 07:39:28AM -0500, Dirk Eddelbuettel wrote:
| > | >  b) when I add it as in
| > | > 
| > | >      PKG_CHECK_MODULES([CPPUNIT], [cppunit >= 1.12.1])
| > | > 
| > | >    it doesn't somehow make it into configure so built still fails
| > | 
| > | Works for me. I fixed zipios++ in exactly that way:
| > 
| > Not for me.
| > 
| > There were some autoconf changes. I am using autoconf (GNU Autoconf) 2.69, 
ie
| > the default on Ubuntu.  Should I try a different one?  Which is installed on
| > your box?
| 
| $ autoconf --version
| autoconf (GNU Autoconf) 2.69
| Copyright (C) 2012 Free Software Foundation, Inc.
| License GPLv3+/Autoconf: GNU GPL version 3 or later
| <http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html>
| This is free software: you are free to change and redistribute it.
| There is NO WARRANTY, to the extent permitted by law.
| 
| Written by David J. MacKenzie and Akim Demaille.
| $
| 
| (as of debian sid)
| 
| You have pkg-config installed? Because only if it is you get the 
PKG_CHECK_MDOULES

Failure was in pbuilder with current sid and of course pkg-config added to 
Build-Depends.

But I see you added dh-autoreconf. That's what I was missing.

Thanks for the cluebat.

Dirk

| macro found and imported. That's what I also forgot in my first zipios++ 
upload(s). Mentioned
| patch + autoreconf works fine here and on the buildds:
| 
https://buildd.debian.org/status/fetch.php?pkg=zipios%2B%2B&arch=i386&ver=0.1.5.9%2Bcvs.2007.04.28-9&stamp=1494311889&raw=0
| 
| Did do it with jags now:
| 
| $ debdiff jags_4.2.0-2.dsc jags_4.2.0-2.1.dsc 
| diff -u jags-4.2.0/debian/changelog jags-4.2.0/debian/changelog
| --- jags-4.2.0/debian/changelog
| +++ jags-4.2.0/debian/changelog
| @@ -1,3 +1,11 @@
| +jags (4.2.0-2.1) unstable; urgency=medium
| +
| +  * Non-maintainer upload.
| +  * use PKG_CHECK_MODULES for cppunit instead of AM_PATH_CPPUNIT
| +    (closes: #862132) 
| +
| + -- Rene Engelhard <r...@debian.org>  Tue, 09 May 2017 12:52:45 +0000
| +
|  jags (4.2.0-2) unstable; urgency=medium
|  
|    * debian/jags.postinst: Add missing shebang                (Closes: 
#843290)
| diff -u jags-4.2.0/debian/control jags-4.2.0/debian/control
| --- jags-4.2.0/debian/control
| +++ jags-4.2.0/debian/control
| @@ -2,7 +2,7 @@
|  Section: math
|  Priority: optional
|  Maintainer: Dirk Eddelbuettel <e...@debian.org>
| -Build-Depends: debhelper (>= 7.0.50~), gfortran (>= 4:5.2), liblapack-dev, 
libltdl-dev (>= 2.2.6b), texlive-base, texlive-latex-base, 
texlive-generic-recommended, texlive-fonts-recommended, texlive-extra-utils, 
texlive-latex-recommended, texlive-latex-extra, texinfo, autotools-dev, 
faketime, g++ (>= 4:5.2), libcppunit-dev
| +Build-Depends: debhelper (>= 7.0.50~), gfortran (>= 4:5.2), liblapack-dev, 
libltdl-dev (>= 2.2.6b), texlive-base, texlive-latex-base, 
texlive-generic-recommended, texlive-fonts-recommended, texlive-extra-utils, 
texlive-latex-recommended, texlive-latex-extra, texinfo, autotools-dev, 
faketime, g++ (>= 4:5.2), libcppunit-dev (>= 1.12.1), dh-autoreconf, pkg-config
|  Standards-Version: 3.9.8
|  Homepage: http://www-fis.iarc.fr/~martyn/software/jags/
|  
| diff -u jags-4.2.0/debian/rules jags-4.2.0/debian/rules
| --- jags-4.2.0/debian/rules
| +++ jags-4.2.0/debian/rules
| @@ -26,3 +26,3 @@
|  %:
| -     dh $@
| +     dh $@ --with autoreconf
|  
| only in patch2:
| unchanged:
| --- jags-4.2.0.orig/configure.ac
| +++ jags-4.2.0/configure.ac
| @@ -31,7 +31,7 @@
|  AC_CONFIG_MACRO_DIR([m4])
|  AC_CONFIG_HEADERS([config.h])
|  AM_INIT_AUTOMAKE([subdir-objects])
| -AM_PATH_CPPUNIT(1.12.1)
| +PKG_CHECK_MODULES(CPPUNIT, cppunit >= 1.12.1)
|  
|  dnl libtool and ltdl configuration
|  LT_PREREQ(2.2.6)
| 
| as the trivial patch works fine. Didn't invent a patch system here so direct 
patching, but
| you should get the idea.
| 
| Checks fine for cppunit
| 
| checking for pkg-config... /usr/bin/pkg-config
| checking pkg-config is at least version 0.9.0... yes
| checking for CPPUNIT... yes
| 
| and builds to the end.
| 
| Regards,
| 
| Rene

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

Reply via email to