Control: tags -1 +patch

Hi!
The failure comes from the assumption that char is signed.  That's true on
x86 and mips, but not on a number of other architectures.

A proper fix would require changing hundreds of places in the code; a quick
and dirty patch of compiling with -fsigned-char risks some trouble when
using external headers, but it appears to work for me -- at least it builds
ok and passes the testsuite.

Tested on arm64 and armhf, I assume the patch should also help on armel
ppc64el s390x powerpc ppc64; the FTBFS on x32 is unrelated.

-- 
⢀⣴⠾⠻⢶⣦⠀ Meow!
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Collisions shmolisions, let's see them find a collision or second
⠈⠳⣄⠀⠀⠀⠀ preimage for double rot13!
diff -Nru form-4.1/debian/changelog form-4.1/debian/changelog
--- form-4.1/debian/changelog	2016-07-29 11:55:40.000000000 +0200
+++ form-4.1/debian/changelog	2017-04-21 21:55:58.000000000 +0200
@@ -1,3 +1,10 @@
+form (4.1-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTBFS on architectures with unsigned char (arm*, ppc*, s390x).
+
+ -- Adam Borowski <kilob...@angband.pl>  Fri, 21 Apr 2017 21:55:58 +0200
+
 form (4.1-1) unstable; urgency=medium
 
   * Initial release. (Closes: #832903)
diff -Nru form-4.1/debian/rules form-4.1/debian/rules
--- form-4.1/debian/rules	2016-07-29 11:55:40.000000000 +0200
+++ form-4.1/debian/rules	2017-04-21 21:04:29.000000000 +0200
@@ -5,6 +5,7 @@
 
 # see FEATURE AREAS in dpkg-buildflags(1)
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export DEB_CFLAGS_MAINT_APPEND = -fsigned-char
 
 %:
 	dh $@ --with autotools_dev --parallel

Reply via email to