Hi Jeff, Am Mittwoch, 5. April 2017, 22:10:51 CEST schrieb Jeff: > Thanks for your patches. I have committed everything up to "Canvas.pm: > fix box offsets & text rotation" and pushed the commits, plus some of my > own to the repo on Sourceforge. Saw then in 1.8.0. Thanks!
> At the moment, there are no unit tests for Gscan2pdf::Canvas, and as > prefer to work test-driven, I would like a test which would fail without > this patch. I pdated the remaining patches, updated existing unit tests that failed with my changes and added some additional unit tests. You can find them in my github branch https://github.com/marschap/gscan2pdf/tree/updates_to_1.8.0 > I am not 100% sure what problem your patch fixes, so would you mind > constructing such a unit test? I would then have no problem committing > the patch. Unfortunately I did not get around to writing a unit test for the "Canvas.pm: fix box offsets & text rotation", as this patch fixes graphical glitches: - in the OCR it draws bounding boxes of hOCR elements where they belong - in the OCR tab it draws left-rotated text correctly rotated Simply test with tesseract and rotated text with and without my patches to see the difference. If you have an idea how to check for such kind of issues in a unit test, .... > The unit test would probably have to defined a page with some boxes > before calling Gscan2pdf::Canvas->new() followed by canvas2hocr() and > check the hocr output. See my additions to 17_Canvas.t Hoping to get the patches included Peter -- Peter Marschall pe...@adpm.de
