On 1 April 2017 at 09:20, Коля Гурьев <guriev...@ya.ru> wrote: > Very good! Does the program really work? You can run it or send a message?
I have only been able to test on armhf, but it does work and I was able to send a message. > One of these macros is used in Telegram/SourceFiles/ui/animation.h:169 > > #ifdef ARCH_CPU_32_BITS > #define SHIFTED_USE_32BIT > #endif // ARCH_CPU_32_BITS > > #ifdef SHIFTED_USE_32BIT > ... I didn't make any changes here and I didn't see any obvious problem with animation, but it would be better to use a portable method of detecting 32-bit register size and defining SHIFTED_USE_32BIT accordingly. I am guessing it should be defined on i386 and armhf, but not on amd64, arm64 and x32. > Also have a look at Telegram/SourceFiles/config.h:276 > > #if Q_BYTE_ORDER == Q_BIG_ENDIAN > #error "Only little endian is supported!" > #endif // Q_BYTE_ORDER == Q_BIG_ENDIAN Unfortunately Ubuntu do not currently have any big-endian PPA builders for public use, so I didn't see a failure because of this. I would still not limit the building architectures, rather allowing the build to fail. Hopefully a big-endian porter takes an interest.
