Control: tags -1 moreinfo
Wouter Verhelst:
> Package: release.debian.org
> Severity: normal
> User: release.debian....@packages.debian.org
> Usertags: unblock
>
> Please unblock package logtool
>
> logtool hadn't been updated in almost 7 years (upstream hasn't been
> active, and the package seemed to still work), but the recent binNMU
> that was done to rebuild with PIE triggered an RC bug in the upgrade
> path.
>
> The main fix is a rework of the configuration system to fix the
> above-mentioned RC bug, but while at it, I refreshed the autotools
> build system (which required a few changes to configure.in to make it
> work with modern autotools) and bumped the debhelper compat level as
> well as the Standards-Version.
>
> wouter@gangtai:~/debian$ debdiff logtool_1.2.8-8.dsc logtool_1.2.8-9.dsc |
> diffstat
> Makefile | 1
> conf/logtool.conf | 30 -
> conf/logtool.conf.in | 30 -
> config.h | 96 +++--
> configure.in | 6
> debian/dirs | 6
> debian/preinst | 17
> install-sh | 704
> +++++++++++++++++++++++++-------------
> logtool-1.2.8/debian/changelog | 23 +
> logtool-1.2.8/debian/compat | 2
> logtool-1.2.8/debian/control | 2
> logtool-1.2.8/debian/logtool.dirs | 21 +
> logtool-1.2.8/debian/postinst | 16
> logtool-1.2.8/src/Makefile | 22 -
> src/Makefile.in | 19 -
> 15 files changed, 665 insertions(+), 330 deletions(-)
>
> full debdiff attached
>
> unblock logtool/1.2.8-9
>
> [...]
Hi Wouter,
Thanks for fixing this bug.
I got two remarks for this upload:
1) Please undo the compat bump; it causes actions at a distance that
hard to reason about from a diff and as such we have it as a defacto
policy to reject that kind of change
2) src/Makefile makes an explicit reference to your build path
(/home). Given it is autotools, I assume that file replaced during
build and therefore it will "just work(tm)".
Without the compat bump (and you signing off on the src/Makefile thing),
I am happy to accept the change.
Thanks,
~Niels
