Hi,

Please find attached a path which fixes the issue. Since I was fixing issue in 
git I have as well pushed changes to github and attached pull-request. To test 
the changes I have made a package with changes applied to new upstream version 
and uploaded it to mentors.debian.org: 
https://mentors.debian.net/package/shairport-sync

Alternatively you can download the package from mentors with dget:
dget -x 
https://mentors.debian.net/debian/pool/main/s/shairport-sync/shairport-sync_3.0.2-0.1.dsc


I am new to the Debian packaging and I am not sure if I am doing the things 
correctly. Could you let me know what should I do in the future. Is it 
preferable to create and send patched on BTS, or doing it in git repository and 
sending pull-requests is preferred way? And if creating packages with changes 
applied is any use to maintainers? I would as well appreciate any other 
comments you have.

Regards
Denys Berkovskyy

Attachment: 0001-Add-shairport-sync-user-and-group-removal-to-postrm.patch
Description: Binary data

The following changes since commit ab43e10e51e3da4296bea600d8d9e53a7179f1b0:

  Upload 2.8.6-1 to unstable (2016-11-11 15:41:09 +0000)

are available in the git repository at:

  https://github.com/berkovskyy/debian-shairport-sync.git master

for you to fetch changes up to 0aa521227d6dc9f240e736aa88b5e6fe9fd955cc:

  Upload 3.0.2-0.1 to unstable (2017-03-23 11:39:23 +0000)

----------------------------------------------------------------
Denys Berkovskyy (5):
      Update changelog for 3.0.2
      Merge tag 'upstream/3.0.2'
      Refresh patches
      Add shairport-sync user and group removal to postrm script in case of 
packet purging.
      Upload 3.0.2-0.1 to unstable

Jief (4):
      constant 0x100000000 should be 0x100000000LL to avoid warning
      Using Macro instead of LL to make it portable.
      Using macro instead of LL to make it portable
      clock_drift could be left uninitialized.

Jörg Krause (2):
      mdns: avahi: set AVAHI_CLIENT_NO_FAIL in avahi_client_new()
      mdns: avahi: handle avahi client failure

Mike Brady (157):
      Add ability to set output format and output rate
      fix tiny syntax error
      Great things happening...
      Begin to add in calculations for expanded back end
      Fix a comment typo.
      Start the great trek
      Make it compile -- untested
      Merge support of apple's ALAC decoder
      Make the decoder choice a bit more general, highlight names of input 
format parameters
      Small improvements
      Apple ALAC decoder not working -- magic cookie contents are faulty.
      Begin to add support for monotonic 64-bit timestamps and frame sequence 
numbers
      Add more support for monotonic 64-bit timestamps and frame sequence 
numbers
      Enable 64-bit monotonic rtptime calculations
      Fix a few little bugs associated with outputing at a higher rate
      Add code to change format from 16 to 24 and 32 bit and to change sample 
rates
      Adding rate and format transformation stuff
      Working reliably with all 16-bit speeds
      Working reliably with all 16-bit speeds
      Change over to times as opposed to frames for setting timing options
      Change over to times as opposed to frames for setting timing options
      Fix small bug introduced moving over to time-based settings
      Stop multiplying monotonic timestamps by the output to input sampling 
ratio
      Fix silence bug and hack code to avoid the stuff procedures
      Fix silence bug and hack code to avoid the stuff procedures
      Preliminary support for 32-bit stuffing
      Preliminary support for 32-bit stuffing
      Add a fancy 64-bit pseudo random number generator -- thanks to its 
developers
      Add a fancy 64-bit pseudo random number generator -- thanks to its 
developers
      Remove prng initialisation code -- it's not needed
      Remove mersenne generator -- too slow, try another one
      Get dither mask working right
      Begin to add full-scale post processing. Does not compile.
      New backend for converting 32-bit "native" samples to output format ready 
for testing
      New backend for converting 32-bit "native" samples to output format ready 
for testing
      Some bug fixes and hacks. Not working.
      Add initial support for U8 and S8 formats
      Beginning to work, also added S8 and U8 support as VMWare Fusion and the 
Pi both offer them
      Tidy up with a clang-format
      Soxr interpolation working.
      Fix 8-bit dithering, fix software volume control
      format player.c
      Soxr interpolation working. Dithering seems to work. Software volume 
seems to work
      trying to get a sane build numbering system. 'd' for 'development'...
      Make endian-independent. Allow users to specify only U8/S8/S16/S24/S32
      Make endian-independent. Allow users to specify only U8/S8/S16/S24/S32
      Fix error checking of alsa latency and buffer legth settings.
      Get different playback modes working and update the configuration sample
      Change names of drift, resync, alsa buffer offset and alsa buffer length 
to distinguish them from the old 44100-based settings. Add warning messages.
      Tidy up source with clang-format
      Change names of drift, resync, alsa buffer offset and alsa buffer length 
to distinguish them from the old 44100-based settings. Add warning messages.
      If sync disabled on the alsa device, don't keep asking for buffer length. 
Also emit sender IP number as metadata.
      If sync disabled on the alsa device, don't keep asking for buffer length. 
Also emit sender IP number as metadata.
      Merge remote-tracking branch 'upstream/development' into development     
Merging 3.0d to 2.8.4.8
      Fix a few typos in the comments
      Version 3.0d!
      3.0d15!
      Version 3.0!
      Version 3.0!
      Version 3.0!
      Add *untested* support for S24_3LE and S24_3BE output format.
      Add *untested* support for S24_3LE and S24_3BE output format.
      Add *untested* support for S24_3LE and S24_3BE output format.
      Merge branch 'development' of https://github.com/mikebrady/shairport-sync 
into development
      3.0d16 – added 24-bit three-byte support
      3.0d16 – 24-bit three-byte support
      2.8.6
      Merge pull request #411 from jief666/rtsp1
      Merge pull request #428 from joerg-krause/patch-2
      Merge pull request #429 from jneubrand/fix-clip
      Merge pull request #431 from jneubrand/development
      Merge pull request #418 from jief666/sugg
      Merge pull request #433 from shtirlic/libsoundio
      Fix small bug
      Add support for mbed TLS and deprecate polarssl support
      Note addition of support for mbed TLS and deprecate polarssl support
      Add support for mbed TLS
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Use mbed TLS instead of PolarSSL
      Recognise and use deprecated settings and issue warnings.
      Add possibility of using an array of precalculated pseudo random numbers 
to reduce processor load.
      Merge branch 'development' of github.com:mikebrady/shairport-sync into 
development
      Add nice deprecations
      Update configure.ac
      Include some information about Apple ALAC
      Use a precalculated array of pseudorandom numbers to do dither, reducing 
runtime load on low-powered processors.
      Update RELEASENOTES.md
      Update configure.ac
      Update .travis.yml
      Try if it's got libmbedtls-dev
      Only check systemd stuff if systemd has been asked for.
      Fix a bug whereby the resync time would be zero, meaning no resync would 
occur.
      Update configure.ac
      Update RELEASENOTES.md
      Update .travis.yml
      Ensure apple_alac and the associated libstdc++ is not included unless 
apple_alac is selected.
      Ensure apple_alac and the associated libstdc++ is not included unless 
apple_alac is selected.
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Add a new setting to specify the interface the service should be provided 
on.
      Add a new setting to specify the interface the service should be provided 
on.
      Update RELEASENOTES.md
      Update shairport-sync.conf
      Update shairport-sync.conf
      Update shairport-sync.conf
      Update shairport-sync.conf
      Update shairport-sync.conf
      Add volume_max_db setting which works on the hw mixer if it exists or the 
sw attenuator otherwise.
      Add volume_max_db setting which works on the hw mixer if it exists or the 
sw attenuator otherwise.
      Update RELEASENOTES.md
      Update shairport-sync.conf
      Update shairport-sync.conf
      Update shairport-sync.conf
      Update shairport-sync.conf
      Include interface and max_volume_db in the debug message
      Update README.md
      Update README.md
      Update README.md
      Update README.md
      Update README.md
      Update README.md
      Start updating man pages for version 3.
      Tiny documentation update
      Update README.md
      Update README.md
      Update README.md
      3.0 Release Candidate 0
      Clang Format
      Update man page and equivalent html page
      Update LICENSES
      Update shairport-sync.conf
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Update RELEASENOTES.md
      Move to version 3.0
      Move to version 3.0
      Updated for Version 3.0
      Version 3.0
      Version 3
      Version 3
      Version 3.0
      Update README.md
      Resore ID of ShairportSync in Bonjour advertisiment and fix a noisy bug 
when a frame was missing
      Resore ID of ShairportSync in Bonjour advertisment like 2.8.6 and fix a 
noisy bug when a frame was missing
      Update RELEASENOTES.md
      Add reference to `–with-tinysvcmdns`, duh.
      Update CYGWIN.md
      Stop checking for default rate and depth. Now, simply ignore the rate and 
depth information.
      Update RELEASENOTES.md
      Small backend updates.

jief666 (2):
      Merge pull request #1 from jief666/rtsp1
      Merge pull request #2 from mikebrady/master

jneubrand (2):
      Fix ClientIP info in metadata     Metadata was previously reporting 
server ip as client ip "ssnc-clip".     Fixed by:     - providing remote_ip 
data instead of ip data for metadata in rtsp.c     - continuing export of ip 
data under "ssnc-svip" metadata tag
      Merge fix-clip

shtirlic (1):
      Initial support for libsoundio

 .travis.yml                                                |   18 +-
 CYGWIN.md                                                  |    3 +-
 LICENSES                                                   |    3 +
 Makefile.am                                                |   11 +-
 README.md                                                  |   90 ++++---
 RELEASENOTES.md                                            |  114 +++++++-
 UPDATING.md                                                |    4 +-
 alac.c                                                     | 1566 
+++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------
 alac.h                                                     |   61 ++---
 apple_alac.cpp                                             |   55 ++++
 apple_alac.h                                               |   20 ++
 audio.c                                                    |   12 +-
 audio.h                                                    |   10 +-
 audio_alsa.c                                               |  681 
+++++++++++++++++++++++++++--------------------
 audio_ao.c                                                 |   74 ++++--
 audio_dummy.c                                              |    8 +-
 audio_pipe.c                                               |   92 +++++--
 audio_pulse.c                                              |   17 +-
 audio_sndio.c                                              |    8 +-
 audio_soundio.c                                            |  215 
+++++++++++++++
 audio_stdout.c                                             |  101 ++++---
 common.c                                                   |  292 
++++++++++++++++----
 common.h                                                   |   91 +++++--
 configure.ac                                               |   78 ++++--
 debian/changelog                                           |   10 +
 debian/patches/{typo-fixes.patch => 0001-typo-fixes.patch} |   73 ++---
 debian/patches/series                                      |    2 +-
 debian/shairport-sync.postrm                               |    5 +
 man/shairport-sync.7                                       |  113 ++++----
 man/shairport-sync.7.xml                                   |  196 
++++++--------
 man/shairport-sync.html                                    |  194 
++++++--------
 mdns.c                                                     |   14 +-
 mdns.h                                                     |   17 +-
 mdns_avahi.c                                               |  369 
++++++++++++++------------
 mdns_dns_sd.c                                              |    8 +-
 mdns_external.c                                            |   20 +-
 mdns_tinysvcmdns.c                                         |   85 +++---
 player.c                                                   | 1785 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
 player.h                                                   |   14 +-
 rtp.c                                                      |  319 
+++++++++++-----------
 rtp.h                                                      |   12 +-
 rtsp.c                                                     |  363 
+++++++++++++------------
 rtsp.h                                                     |    1 -
 scripts/shairport-sync.conf                                |   55 ++--
 shairport-sync.spec                                        |    6 +-
 shairport.c                                                |  593 
+++++++++++++++++++++++++++--------------
 tinysvcmdns.c                                              |   26 +-
 47 files changed, 4789 insertions(+), 3115 deletions(-)
 create mode 100644 apple_alac.cpp
 create mode 100644 apple_alac.h
 create mode 100644 audio_soundio.c
 rename debian/patches/{typo-fixes.patch => 0001-typo-fixes.patch} (58%)

Reply via email to