Hi,

On Wed, Mar 22, 2017 at 09:20:45PM +0100, Andreas Beckmann wrote:
> during a test with piuparts I noticed your package ships (or creates)
> a broken symlink.
>
> 0m41.5s ERROR: FAIL: Broken symlinks:
>   /usr/share/portabase/help/_static/jquery.js -> 
> /javascript/sphinxdoc/1.0/jquery.js
>   /usr/share/portabase/help/_static/underscore.js -> 
> /javascript/sphinxdoc/1.0/underscore.js
>   /usr/share/portabase/help/_static/searchtools.js -> 
> /javascript/sphinxdoc/1.0/searchtools.js
>   /usr/share/portabase/help/_static/doctools.js -> 
> /javascript/sphinxdoc/1.0/doctools.js
>
> This looks like you are not using dh_sphinxdoc, but do this manually.

I think the reason is different: this package does use dh_sphinxdoc,
however after building docs it replaces static paths using some sed calls
in packaging/linux/debian.sh, and dh_sphinxdoc does not understand what
happens here.

I can maybe fix this in dh_sphinxdoc: canonicalizing the paths before doing
the symlinking should help.

But I think the portabase package may need an update too. The comment in
packaging/linux/debian.sh says: “generate the help files here, since even
unstable uses an outdated Sphinx”. But resources/help/conf.py has
“needs_sphinx = '1.1'”, and testing ships Sphinx 1.4.9, which should be new
enough (and we had Sphinx 1.1 in 2012), so maybe this hack is not needed
at all.

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature

Reply via email to