James McCoy: > On Mon, Mar 06, 2017 at 11:45:20PM -0500, James McCoy wrote: >> On Thu, Feb 16, 2017 at 05:23:00PM +0000, Ximin Luo wrote: >>> I've done an initial implementation here: >>> >>> https://anonscm.debian.org/cgit/collab-maint/devscripts.git/log/?h=pu/debsign-buildinfo >>> >>> Please review! >> >> This was merged and uploaded in 2.17.2. However, now I see that >> buildinfo files may be arch-qualified even with a _source.changes (e.g., >> by using "sbuild -A --source-only-changes"). That's not currently >> handled properly since "debsign foo_ver_source.changes" expects >> "foo_ver_source.buildinfo" to exist. >> >> Should debsign be deriving the path for the buildinfo from the contents >> of the changes file? > > I've changed all of the "child file" handling to use this approach in > 4a4238dbf1e789e998cf047ea0f006e982fba56b. That seems cleaner than > debsign replicating logic to determine the names of related files. > > [..]
Looks good, yes that is better. Also thanks for fixing the auto-detection of the signer, that was my fault. In 0207d9493a24decfba5e533c2efa75e1e2e335db I deduplicated two pieces of code that looked the same but was actually different, and should have picked the other one to use. :/ X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git
