On Thu, 02 Mar 2017 22:22:01 +0100, gregor herrmann wrote: > > == dh-make-perl 0.93 == > > Trying /PATH/TO/MODULE/DISTRIBUTION/Dn-Role-v0.1/../Dn-Role-v0.1.tar .gz... > > found! > > Using META.json > > Found: Dn-Role 0.1 (libdn-role-perl arch=all) > > Can't locate object method "get_user" via package > > "DhMakePerl::Command::make" at > > /usr/share/perl5/DhMakePerl/Command/Packaging.pm line 130.
> Carnë, this seems to be a side effect of
> 23b15bd799ee7e7f9394119a98bdef510424be3d.
> Could you take a look please? (I'm not sure what the best fix would
> be that fits your refactoring.)
How about this change?
diff --git a/lib/DhMakePerl/Command/Packaging.pm
b/lib/DhMakePerl/Command/Packaging.pm
index 690740a..c54942b 100644
--- a/lib/DhMakePerl/Command/Packaging.pm
+++ b/lib/DhMakePerl/Command/Packaging.pm
@@ -119,6 +119,12 @@ sub makefile_pl {
return $self->main_file('Makefile.PL');
}
+sub get_user {
+ my $self = shift;
+ my $user = $ENV{LOGNAME} || $ENV{USER};
+ return $user;
+}
+
sub get_email {
my $self = shift;
my $email = $self->cfg->email;
@@ -138,7 +144,7 @@ sub get_name {
my $self = shift;
my $name;
- my $user = $ENV{LOGNAME} || $ENV{USER};
+ my $user = $self->get_user;
my $pwnam = getpwuid($<);
die "Cannot determine current user\n" unless $pwnam;
if ( defined $ENV{DEBFULLNAME} ) {
An alternative would be to drop the non-existing get_user() call from
get_email() and use
my $user = $ENV{LOGNAME} || $ENV{USER};
$email = $user ...
there; but this duplicates the user setting.
Cheers,
gregor
--
.''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Rolling Stones
signature.asc
Description: Digital Signature
