Package: synaptic
Version: 0.84.1
Severity: important
Tags: patch
User: pkg-gnome-maintain...@lists.alioth.debian.org
Usertags: gksu oldlibs

synaptic Recommends gksu|kdebase-bin|policykit-1, leading to a default GNOME
desktop installation containing gksu. However, it does not actually use gksu:
since 0.75.12, the .desktop and .menu files both run synaptic-pkexec, which
unconditionally uses pkexec. So the menu entries won't actually work unless
policykit-1 is installed.

This makes synaptic (via gksu) one of the last few packages in a GNOME desktop
installation to pull in gconf, which the GNOME maintainers would like to
eradicate.

I attach a possible patch.

Additionally, this would fix long-standing bug #415408 by ensuring that
synaptic depends on all the necessary packages to make its menu entry work.

Regards,
    S
diffstat for synaptic-0.84.1 synaptic-0.84.1+nmu1

 configure.in     |    2 +-
 debian/changelog |   11 +++++++++++
 debian/control   |    4 ++--
 3 files changed, 14 insertions(+), 3 deletions(-)

diff -Nru synaptic-0.84.1/configure.in synaptic-0.84.1+nmu1/configure.in
--- synaptic-0.84.1/configure.in	2017-01-06 21:22:49.000000000 +0000
+++ synaptic-0.84.1+nmu1/configure.in	2017-03-01 21:51:18.000000000 +0000
@@ -1,7 +1,7 @@
 dnl Process this file with autoconf to produce a configure script.
 AC_INIT(configure.in)
 
-AM_INIT_AUTOMAKE(synaptic, 0.84.1)
+AM_INIT_AUTOMAKE(synaptic, 0.84.1+nmu1)
 AM_CONFIG_HEADER(config.h)
 AM_MAINTAINER_MODE
 
diff -Nru synaptic-0.84.1/debian/changelog synaptic-0.84.1+nmu1/debian/changelog
--- synaptic-0.84.1/debian/changelog	2017-01-06 21:22:49.000000000 +0000
+++ synaptic-0.84.1+nmu1/debian/changelog	2017-03-01 21:51:18.000000000 +0000
@@ -1,3 +1,14 @@
+synaptic (0.84.1+nmu1) UNRELEASED; urgency=medium
+
+  * Depend on policykit-1 instead of recommending
+    gksu|kdebase-bin|policykit-1. data/synaptic.desktop.in and
+    debian/synaptic.menu both use debian/synaptic-pkexec, which
+    unconditionally runs pkexec. (Closes: #nnnnnn)
+    - Pushing the recommendation up to a Depends ensures that the menu
+      entry can in fact be launched (Closes: #415408)
+
+ -- Simon McVittie <s...@debian.org>  Wed, 01 Mar 2017 21:51:18 +0000
+
 synaptic (0.84.1) unstable; urgency=medium
 
   [ Vadim Kalmakov ]
diff -Nru synaptic-0.84.1/debian/control synaptic-0.84.1+nmu1/debian/control
--- synaptic-0.84.1/debian/control	2017-01-06 21:22:49.000000000 +0000
+++ synaptic-0.84.1+nmu1/debian/control	2017-03-01 21:51:18.000000000 +0000
@@ -10,9 +10,9 @@
 
 Package: synaptic
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, hicolor-icon-theme
+Depends: ${shlibs:Depends}, ${misc:Depends}, hicolor-icon-theme, policykit-1
 Conflicts: menu (<< 2.1.11)
-Recommends: gksu|kdebase-bin|policykit-1, libgtk2-perl (>= 1:1.130), rarian-compat, xdg-utils
+Recommends: libgtk2-perl (>= 1:1.130), rarian-compat, xdg-utils
 Suggests: dwww, menu, deborphan, apt-xapian-index, tasksel, software-properties-gtk
 Description: Graphical package manager 
  Synaptic is a graphical package management tool based on GTK+ and APT.

Reply via email to