On 02/26/2017 03:49 PM, Ximin Luo wrote:
> Erwan Prioul:
>> Hi,
>>
>> I've been able to build the rust package on ppc64el with the attached patch.
>> In the patch:
>>  * workaround to avoid issue with the tests smoke_dtor and 
>> test_typed_arena_drop_small_count: no optimization on ppc64el
>>  * add ignore flags to asm test files that have no meaning for ppc64el
>>  * add a reference to a library in a makefile
>>
>> Thanks for considering the patch.
>>
> 
> Hi Erwan, thanks for the patch! I've applied it in our git, and going to test 
> it soon.
> 
> However could you explain d-missing-ref-dlsym-ppc64el.patch a bit and why 
> it's not suitable for upstream?

This patch adds a reference to the dl library. Without it, the related test 
fails with: "undefined reference to `dlsym'", at least on ppc64el.
Actually, my patch is quite rough, it misses a test about the architecture to 
add or not the option -ldl.

Erwan.

Reply via email to