Control: tags -1 + patch
On Fri, 2017-02-24 at 19:13 +0000, Dmitriy Getman wrote:
> package: devscripts
> version: 2.17.1
> I added more verbose output for script checkbashisms:
> possible bashism in ../bash/saymyname line 45 ($MACHTYPE should be
> "$(gcc -dumpmachine"):
>
> possible bashism in ../bash/saymyname line 188 ($HOSTNAME should be
> "$(uname -n)"):
Thanks for the update.
In general, please provide patches against the existing script, rather
than complete new scripts. I've done so now, and attached the patch.
Regards,
Adam
--- scripts/checkbashisms.pl 2016-10-01 16:15:56.659665607 +0100
+++ /home/adam/.cache/evolution/tmp/evolution-adam-UUToFC/checkbashisms.pl 2017-02-24 20:10:51.680837263 +0000
@@ -665,8 +665,10 @@
qr'\$\{(?:\w+|@|\*)(/.+?){1,2}\}' => q<${parm/?/pat[/str]}>,
qr'\$\{\#?\w+\[.+\](?:[/,:#%^].+?)?\}' => q<bash arrays, ${name[0|*|@]}>,
qr'\$\{?RANDOM\}?\b' => q<$RANDOM>,
- qr'\$\{?(OS|MACH)TYPE\}?\b' => q<$(OS|MACH)TYPE>,
- qr'\$\{?HOST(TYPE|NAME)\}?\b' => q<$HOST(TYPE|NAME)>,
+ qr'\$\{?OSTYPE\}?\b' => q<$OSTYPE>,
+ qr'\$\{?MACHTYPE\}?\b' => q<$MACHTYPE should be "$(gcc -dumpmachine">,
+ qr'\$\{?HOSTTYPE\}?\b' => q<$HOSTTYPE should be "$(uname -m)">,
+ qr'\$\{?HOSTNAME\}?\b' => q<$HOSTNAME should be "$(uname -n)">,
qr'\$\{?DIRSTACK\}?\b' => q<$DIRSTACK>,
qr'\$\{?EUID\}?\b' => q<$EUID should be "$(id -u)">,
qr'\$\{?UID\}?\b' => q<$UID should be "$(id -ru)">,
