Control: tag -1 +moreinfo Dear Jeroen,
Thanks for your packaging work! I cannot sponsor the upload, but here're a few comments after reviewing your package. On Sun, Dec 25, 2016 at 5:39 PM, Jeroen van Aart <andr...@e-quake.org> wrote: > > I am looking for a sponsor for my package "mate-equake-applet" > > * Package name : mate-equake-applet > Version : 1.3.8-1 > Upstream Author : Jeroen van Aart > * URL : http://www.e-quake.org > * License : GPL > Section : x11 Here're the items need to be fixed: - inconsistent on license: COPYING shows the project is under GPL-3+ however, source files under src/ folder and debian/copyright shows GPL-2+ - license of image file: icons/48x48/mate-equake-applet-icon.png Please confirm its license with upstream (you?), usually license of image files is different from the code. - license of install-sh is differrent, you need to sort it out - lintian reports: Former 2 should be easy, last one can be fixed later. W: mate-equake-applet source: ancient-standards-version 3.9.5 (current is 3.9.8) I: mate-equake-applet: spelling-error-in-binary usr/lib/x86_64-linux-gnu/mate-equake-applet Minimun Minimum I: mate-equake-applet: hardening-no-bindnow usr/lib/x86_64-linux-gnu/mate-equake-applet Other comments, nice to have: - it's more convenient if you can export your work to some modern SCM, such as git the review will be easier if doing with such SCM you can omit the final releasing commit, so if there's something still need to work, you don't have to push forcefully. - add Vcs-* line to d/control (depends on the above item) - bump to debhelper 10 - In favor of https URL over http in debian/copyright - there're a few warnings during build, better fix them if possible I don't use mate, so just a review from source side. Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
