On 2017-01-29 21:46, Vincent Lefevre wrote: > On 2017-01-29 15:54:36 +0000, Andy Simpkins wrote: > > Back in August *2015* there was a short discussion regarding removing > > sonsord from lm-sensors as a result of this bug. > > > > Because it is marked as GRAVE, this bug is release critical for Stretch. > > > > Is this really a grave bug, should it be down graded? > > This is data loss. Downgrading the bug would be a bad idea. > Why not just simply fix it?
Strictly speaking it's not data loss. New data is not acquired anymore, but the old data is still available and not lost. > > Can Sensord be removed? > > If it is too broken and unfixable, then it should be removed, which > would be a simple way (though not the best way) to fix the bug as a > consequence. What's the point of keeping something that no longer > works? I disagree it does not longer work to the point it is not longer usable. The logging to an RRD database is broken in some cases (see below), but logging to syslog, ie the default configuration, still works perfectly. Now removing sensord is clearly an option, as it hasn't seen any recent changes upstream, but also because it's not compiled by default in the upstream Makefile. The other alternative is disabling the RRD part of sensord. > > Is there another option? > > > > It seams to me that if you depend on the structure of a file that > > changes you could simply re-initialise sensord passing it the new > > structure. > > What do you mean? Note that rebooting the machine doesn't solve the > problem. On a different machine, I still have: > > [...] > Jan 29 21:35:00 ypig sensord: Error updating RRD file: /var/log/sensord.rrd: > /var/log/sensord.rrd: found extra data on update argument: 0.040000 > Jan 29 21:35:00 ypig sensord: rrd update error (-1) > Jan 29 21:40:00 ypig sensord: Error updating RRD file: /var/log/sensord.rrd: > /var/log/sensord.rrd: found extra data on update argument: 0.000000 > Jan 29 21:40:00 ypig sensord: rrd update error (-1) > Jan 29 21:45:00 ypig sensord: Error updating RRD file: /var/log/sensord.rrd: > /var/log/sensord.rrd: found extra data on update argument: 0.140000 > Jan 29 21:45:00 ypig sensord: rrd update error (-1) It's not a question of rebooting the machine, but moving out this RRD file and creating a new one. The problem is that all the values returned by the sensor drivers are stored in a single file, so the problem arise if the number of value to be stored changes since the file has been created. This means that loading or unloading sensors modules, or using a new kernel which changes the values returned by some sensors modules will trigger this issue. This is why the manpage states "It is expected that all required sensor modules are loaded prior to this daemon being started". Please also note that it's not a new bug that has been introduced recently, it has probably always been there and can easily be triggered by loading or unloading kernel modules. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
signature.asc
Description: PGP signature
