Bug#851318: uglifyjs: FTBFS on slow machines (failing tests)

[Santiago Vila]

Package: src:uglifyjs
Version: 2.7.5-1
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
test -x debian/rules
mkdir -p "."

Scanning upstream source for new/changed copyright notices...

set -e; LC_ALL=C.UTF-8 /usr/bin/licensecheck --check '.*' --recursive 
--copyright --deb-fmt --ignore 
'^(debian/(changelog|copyright(|_hints|_newhints)))$' --lines 0 * | 
/usr/lib/cdbs/licensecheck2dep5 > debian/copyright_newhints
9 combinations of copyright and licensing found.
WARNING:                        New or changed notices discovered:

 package.json

To fix the situation please do the following:
  1) Examine debian/copyright_* and referenced files

[... snipped ...]

    Running test [lift_sequences_3]
    Running test [lift_sequences_4]
    Running test [for_sequences]
--- string-literal.js
    Running test [octal_escape_sequence]
--- switch.js
    Running test [constant_switch_1]
    Running test [constant_switch_2]
    Running test [constant_switch_3]
    Running test [constant_switch_4]
    Running test [constant_switch_5]
    Running test [constant_switch_6]
    Running test [constant_switch_7]
    Running test [constant_switch_8]
    Running test [constant_switch_9]
    Running test [drop_default_1]
    Running test [drop_default_2]
    Running test [keep_default]
--- typeof.js
    Running test [typeof_evaluation]
    Running test [typeof_in_boolean_context]
--- unicode.js
    Running test [unicode_parse_variables]
--- wrap_iife.js
    Running test [wrap_iife]
    Running test [wrap_iife_in_expression]
    Running test [wrap_iife_in_return_call]

  --- Sourcemaps tests
․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  
․․․․․․․․․․․․

  66 passing (34s)
  1 failing

  1) bin/uglifyjs should produce a functional build when using --self:
     Error: timeout of 5000ms exceeded
      at null.<anonymous> (/usr/lib/nodejs/mocha/lib/runnable.js:139:19)
      at Timer.listOnTimeout (timers.js:92:15)



debian/rules:52: recipe for target 'debian/stamp-build' failed
make: *** [debian/stamp-build] Error 1
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/uglifyjs/

If this is really a bug in one of the build-depends, please use reassign and 
affects,
so that this is still visible in the page for this package.

I can reproduce this in a lot of different computers, all being "slow",
but there is not a policy anywhere saying that autobuilders must be fast,
so I'm not treating this one as a FTBFS-randomly bug.

Thanks.