Control: tags -1 - patch + confirmed moreinfo
Control: found -1 dput/0.11.0

On 17-Jul-2011, Thorsten Glaser wrote:

> dput uploaded the first .changes file, looked at the second and
> decided it was already uploaded… and stopped processing, instead
> of uploading the third one. This was totally unexpected and could
> have led to loss, had I not seen that.

I agree this is undesirable, because the result is that the requested
action (“upload all these releases to the remote host now”) has
aborted with an error, leaving only a partial success.

> Please fix this – already uploaded files for which there is nothing
> more to do must not pre- vent dput from processing the remaining
> files on the command line.

Thinking about possible failure modes, I don't agree with that
suggestion. The result would be another undesirable “partial success”
result.


We can do better, I think. I am inclined to change the behaviour so that:

* Before any uploads, ‘dput’ will check “is there already an upload
  log for this release” for every package changes file.

* If any of them already exist, they are all reported as errors. The
  attempt is then aborted before any upload.

* If none of them already exist, the uploads attempts begin.

That way, the user can address the problem before getting partway
through and encountering the error.

That doesn't quite match your request, but I would still like your
opinion on whether you think this correctly addresses the reported
problem.

-- 
 \           “The long-term solution to mountains of waste is not more |
  `\      landfill sites but fewer shopping centres.” —Clive Hamilton, |
_o__)                                                _Affluenza_, 2005 |
Ben Finney <bign...@debian.org>

Attachment: signature.asc
Description: PGP signature

Reply via email to