Package: src:open-vm-tools
Version: 2:10.1.0-4449150-2
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]

   dh_installdeb -i -O--sourcedirectory=open-vm-tools
   dh_gencontrol -i -O--sourcedirectory=open-vm-tools
dpkg-gencontrol: warning: File::FcntlLock not available; using flock which is 
not NFS-safe
   debian/rules override_dh_md5sums
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_md5sums
# remove broken \ escaping from md5sums
sed -i -e 's,^\\,,' -e 's,\\\\,\\,' debian/open-vm-tools-desktop/DEBIAN/md5sums
sed: can't read debian/open-vm-tools-desktop/DEBIAN/md5sums: No such file or 
directory
debian/rules:126: recipe for target 'override_dh_md5sums' failed
make[1]: *** [override_dh_md5sums] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:8: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit 
status 2
--------------------------------------------------------------------------------

This happens because we are creating arch-independent packages only,
so debian/open-vm-tools-desktop/[...] does not exist.

The trivial fix is to override dh_md5sums only for arch-dependent packages,
as in the patch below.

Warning: I have not actually tested the patch. Please check that both
"dpkg-buildpackage -A" and "dpkg-buildpackage -B" work before uploading.

If you can upload this in source only form (dpkg-buildpackage -S),
even better, as we would get official build logs here:

https://buildd.debian.org/status/package.php?p=open-vm-tools

and bugs like this one would never propagate to testing.

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -122,7 +122,7 @@ override_dh_systemd_start:
 override_dh_installchangelogs:
        dh_installchangelogs ReleaseNotes.md
 
-override_dh_md5sums:
+override_dh_md5sums-arch:
        dh_md5sums
        # remove broken \ escaping from md5sums
        sed -i -e 's,^\\,,' -e 's,\\\\,\\,' 
debian/open-vm-tools-desktop/DEBIAN/md5sums

Reply via email to