Hello Leo, On Thu, Dec 29, 2016 at 09:22:23PM +0100, l...@ndrs.fr wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "gnome-shell-extension-radio", [...]
Thanks for your interest in debian packaging. [...] > Everything is ready except a few contributors informations missing in > `debian/copyright` but I hope it'll to be fixed soon, see [4]. Please note that not all contributors may be copyright holders. If actual copyright holders are missing from debian/copyright that's likely a blocking issue though, as your package likely won't pass through the initial NEW review done by ftp-masters. (You seem to have put work into your debian/copyright and thanks for doing so. Having copyright and licensing information in order is great help for getting the package accepted and shipped in the Debian archive.) > > This is my first Debian package, sorry if I'm doing something wrong... Your package seems mostly fine. I'm not sure why you're overriding the build target in your debian/rules though rather than using override_dh_auto_build:. My main issue though is how to build from the VCS you refer us to? Please document the procedure for working with your source in debian/README.source when you use anything non-standard by choice. (Anything that's not building via a pure dpkg-buildpackage or gbp buildpackage invocation would count in my book as being non-standard. Please note that with gbp you can just ship debian/gbp.conf to make it 'just work'. Having all people who potentially want to build from source jump through hoops is not a good recipe for scalability.) I have thus not actually tried to build your package. Given I've not built it I also can not upload it (and this can't even be considered a complete review of it). > > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849522 > [2] http://213.246.39.125/~leo/packaging/gnome-shell-extension-radio/ > [3] > https://gitlab.com/zapashcanon/gnome-shell-extension-radio-packaging/tree/master/debian > [4] https://github.com/hslbck/gnome-shell-extension-radio/issues/43 Regards, Andreas Henriksson
