Package: sslsniff Version: 0.8-6 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu zesty ubuntu-patch
Dear Maintainer, In Makefile.am, libraries are linked against in LDFLAGS (which is meant for linker options), not LDADD. This causes an FTBFS with ld --as-needed in Ubuntu, where the order of linking matters. See https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries for more information. In Ubuntu, the attached patch was applied to achieve the following: * debian/patches/Add-missing-libraries-at-link-time.patch: Update to add libraries to LDADD instead of LDFLAGS, fixing FTBFS with ld --as-needed. Thanks for considering the patch. Logan Rosen -- System Information: Debian Release: stretch/sid APT prefers yakkety-updates APT policy: (500, 'yakkety-updates'), (500, 'yakkety-security'), (500, 'yakkety'), (100, 'yakkety-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.4.0-21-generic (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
diff -Nru sslsniff-0.8/debian/patches/Add-missing-libraries-at-link-time.patch sslsniff-0.8/debian/patches/Add-missing-libraries-at-link-time.patch --- sslsniff-0.8/debian/patches/Add-missing-libraries-at-link-time.patch 2016-11-22 11:02:04.000000000 -0500 +++ sslsniff-0.8/debian/patches/Add-missing-libraries-at-link-time.patch 2016-12-29 16:24:36.000000000 -0500 @@ -19,6 +19,6 @@ sslsniff_SOURCES = Bridge.hpp SSLConnectionManager.cpp FingerprintManager.hpp FirefoxAddonUpdater.hpp FirefoxUpdater.hpp HTTPSBridge.hpp Logger.hpp RawBridge.hpp SessionCache.hpp SSLBridge.hpp SSLConnectionManager.hpp sslsniff.hpp UpdateManager.hpp certificate/AuthorityCertificateManager.hpp certificate/Certificate.hpp certificate/CertificateManager.hpp certificate/TargetedCertificateManager.hpp http/HttpBridge.hpp http/HttpConnectionManager.hpp http/HttpHeaders.hpp http/OCSPDenier.hpp util/Destination.cpp util/Destination.hpp util/Util.hpp FirefoxUpdater.cpp Logger.cpp SessionCache.cpp SSLBridge.cpp HTTPSBridge.cpp sslsniff.cpp FingerprintManager.cpp certificate/AuthorityCertificateManager.cpp certificate/TargetedCertificateManager.cpp certificate/CertificateManager.cpp http/HttpBridge.cpp http/HttpConnectionManager.cpp http/HttpHeaders.cpp UpdateManager.cpp http/OCSPDenier.cpp FirefoxAddonUpdater.cpp -sslsniff_LDFLAGS = -lssl -lboost_filesystem -lpthread -lboost_thread -llog4cpp -+sslsniff_LDFLAGS = -lssl -lboost_filesystem -lpthread -lboost_thread -llog4cpp -lcrypto -lboost_system ++sslsniff_LDADD = -lssl -lboost_filesystem -lpthread -lboost_thread -llog4cpp -lcrypto -lboost_system EXTRA_DIST = certs/wildcard IPSCACLASEA1.crt leafcert.pem updates/Darwin_Universal-gcc3.xml updates/Linux_x86-gcc3.xml updates/WINNT_x86-msvc.xml
