Bug#849481: amanda-common: Amanda::Changer::robot::Interface::MTX calls confess but does not use Carp

[Will Aoki]

Package: amanda-common
Version: 1:3.3.8-1
Severity: normal
Tags: patch

I've been getting occasional failures that leave the following in the report:

  FAILURE DUMP SUMMARY:
    taper: FATAL Undefined subroutine 
&Amanda::Changer::robot::Interface::MTX::confess called at 
/usr/lib/amanda/perl/Amanda/Changer/robot.pm line 2563.
    backup1.nhmu.utah.edu pool/burp lev 0  FAILED [out of holding space in 
degraded mode]
    backup1.nhmu.utah.edu pool/burp lev 0  FAILED [data write: Broken pipe]

The cause of the failure seems to be a fork failing, but a bug in AMANDA's
error-handling code is masking the first problem. This module calls confess(),
but it doesn't use Carp first or otherwise declare &confess.

--- /tmp/robot.pm       2016-12-27 09:41:57.285488949 -0700
+++ /usr/lib/amanda/perl/Amanda/Changer/robot.pm        2016-12-27 
09:41:34.045222046 -0700
@@ -2359,6 +2359,7 @@
 use Amanda::Debug qw( debug warning );
 use Amanda::MainLoop qw( :GIOCondition synchronized make_cb define_steps step 
);
 use Amanda::Device qw( :constants );
+use Carp;
 
 sub new {
     my $class = shift;