Control: tags -1 - moreinfo Hi Gianfranco,
I've uploaded an updated version of the package to mentors (and also to git on alioth) that fixes these issues. On 12/22/2016 12:29 PM, Christian Seiler wrote: > On 12/22/2016 12:05 PM, Gianfranco Costamagna wrote: >> 1) chmod a-x debian/ondir/usr/share/ondir/integration/* >> >> why no dh_fixperms override? > > I forgot about dh_fixperms, will change that in the next iteration. Done. >> 2) >> CFLAGS_FOR_MAKEFILE=$(shell dpkg-buildflags --get CPPFLAGS) $(shell >> dpkg-buildflags --get CFLAGS) -DVERSION=\"$(VERSION)\" >> -DGLOBAL_CONF=\"/etc/onddirrc\" >> >> I prefer CFLAGS and then CPPFLAGS >> LDFLAGS_FOR_MAKEFILE=$(shell dpkg-buildflags --get CFLAGS) $(shell >> dpkg-buildflags --get LDFLAGS) >> >> why CFLAGS in LDFLAGS? That wasn't actually required, so I dropped it. Additionally, after thinking about what Peter said in this thread, I removed the -DVERSION=... from this line and rather added it to a DEB_CPPFLAGS_MAINT_APPEND, which seems cleaner to me. >> 3) please ask upstream about the "+" in license > > I've sent upstream an email about this. I've done so, received a quick response that v2 or later is ok, and added a comment to d/copyright. Updated package available under: https://mentors.debian.net/package/ondir https://mentors.debian.net/debian/pool/main/o/ondir/ondir_0.2.3+git0.55279f03-1.dsc gbp clone https://anonscm.debian.org/git/collab-maint/ondir.git Regards, Christian
