I agree that it eventually has to be resolved and fixed upstream, but at
least I seem to be unable to find the spot in this haystack of cgroup
things.
So until this bug is properly resolved I'd ask to skip this particular part
of the smoke test.

BTW - the isolation level requirement I mentioned before still applies as
well - the reason is fixed in lxc, but might need an extra tweak to apply
to libvirt-lxc.
https://github.com/lxc/lxc/issues/680 for more on the lxc side of things.

So a "fix" for now to get the smoke test running would be as attached:

Please keep this bug open until the root cause is really resolved.
But I'd ask to apply the patch I atatched to get the rest of your test
coverage up and running independent of this issue for now.
commit fd86517ea921bbcd21f3af678713a2a6f83d0372
Author: Christian Ehrhardt <christian.ehrha...@canonical.com>
Date:   Mon Dec 19 17:05:28 2016 +0100

    workaround for debbug 848317 (lxc restart sometimes kills guests)
    
    Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com>

diff --git a/debian/tests/smoke-lxc b/debian/tests/smoke-lxc
index 7d07815..20e768f 100755
--- a/debian/tests/smoke-lxc
+++ b/debian/tests/smoke-lxc
@@ -37,8 +37,9 @@ virsh start ${DOMAIN}
 grep -qs "starting up" /var/log/libvirt/lxc/sl.log
 check_domain
 # Make sure a restart doesn't termiante the domain
-/etc/init.d/libvirtd restart
-check_domain
+# skip until debbug #848317 is resolved
+#/etc/init.d/libvirtd restart
+#check_domain
 virsh destroy ${DOMAIN}
 virsh undefine ${DOMAIN}
 CLEANED_UP=1
commit 20a59e25a04c81758879bb78b4eb030c50584a25
Author: Christian Ehrhardt <christian.ehrha...@canonical.com>
Date:   Mon Dec 19 17:04:46 2016 +0100

    fixup smoke-lxc tests which requires more isolation
    
    Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com>

Notes:
    This could be a reoccurance of these issues in a different scope:
    https://github.com/lxc/lxc/issues/680
    Maybe the rule needs to get in for libvirt-lxc as well?
    To get the tests running reliably we now set isolation machine which is
    avoiding this for the dep8 test.

diff --git a/debian/tests/control b/debian/tests/control
index 6b99112..f6432d9 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -9,7 +9,7 @@ Restrictions: allow-stderr, isolation-container
 
 Tests: smoke-lxc
 Depends: libvirt-daemon-system, libvirt-clients, libxml2-utils
-Restrictions: allow-stderr, needs-root
+Restrictions: allow-stderr, needs-root, isolation-machine
 
 Tests: build-test
 Depends: libvirt-dev, build-essential, pkg-config

Reply via email to