Package: python-coverage
Severity: normal
Dear Maintainer,
The python-coverage package recommends libjs-jquery-hotkeys and does not
install the jquery.hotkeys.js. However the file found in the coverage.py
sources is different from the file found in libjs-jquery-hotkeys:
--- /tmp/libjs-jquery-hotkeys-0~20130707+git2d51e3a9+dfsg/jquery.hotkeys.js
2016-12-14 23:42:26.000000000 +0100
+++
/home/loic/software/coveragepy/issue-518/coverage.py/coverage/htmlfiles/jquery.hotkeys.js
2016-12-14 20:13:35.576077233 +0100
@@ -22,8 +22,7 @@
96: "0", 97: "1", 98: "2", 99: "3", 100: "4", 101: "5",
102: "6", 103: "7",
104: "8", 105: "9", 106: "*", 107: "+", 109: "-", 110:
".", 111 : "/",
112: "f1", 113: "f2", 114: "f3", 115: "f4", 116: "f5",
117: "f6", 118: "f7", 119: "f8",
- 120: "f9", 121: "f10", 122: "f11", 123: "f12", 144:
"numlock", 145: "scroll", 188: ",", 190: ".",
- 191: "/", 224: "meta"
+ 120: "f9", 121: "f10", 122: "f11", 123: "f12", 144:
"numlock", 145: "scroll", 191: "/", 224: "meta"
},
shiftNums: {
@@ -45,7 +44,7 @@
handleObj.handler = function( event ) {
// Don't fire in text-accepting inputs that we didn't
directly bind to
if ( this !== event.target && (/textarea|select/i.test(
event.target.nodeName ) ||
- event.target.type === "text" ||
$(event.target).prop('contenteditable') == 'true' )) {
+ event.target.type === "text") ) {
return;
}
In order to avoid unintended behavior or regressions, the jquery.hotkeys.js
file provided in the coverage.py sources must be installed.
Although it is desirable to avoid file duplication, this can only be done if
the files are indeed identical or if they are provided by an upstream that
maintains an API of some kind. Although I've not checked, I suspect that other
python-coverage javascript dependencies suffer from the same problem. The bug
reported against coverage.py[1] regarding key bindings could originate from
untested javascript libraries substitution.
Cheers
[1]
https://bitbucket.org/ned/coveragepy/issues/474/javascript-in-html-captures-all-keys
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.4.0-47-generic (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
--
Loïc Dachary, Artisan Logiciel Libre
