Am Sonntag, den 11.12.2016, 12:03 -0500 schrieb Bill Blough: > On Sat, Dec 10, 2016 at 10:27:28AM +0100, Tobias Frost wrote: > > here's the review: > > Thanks! > > > Must-fixes: > > - Please remove the -dbg package in favour of the automatic dbgsym > > packages (https://wiki.debian.org/DebugPackage) > > Done. > > > - Please update to latest standard's version > > Sorry, not sure how I missed that. Done. > > > - lintian's complaining about not enabled hardening. Please check > > if > > you can fix that. > > All of the other hardening flags are getting passed, but for some > reason > that one isn't getting passed or is otherwise not getting applied. > I'll try to > look into what's happening when I have some extra time, but for now, > I added > the flag manually and that fixed it.
I did an test, seems so that adding this to d/rules would also have fixed it: export DEB_BUILD_MAINT_OPTIONS = hardening=+all export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic export DEB_LDFLAGS_MAINT_APPEND := -Wl,--as-needed > > - would be nice if you could bump d/compat level to 10 (and cleanup > > d/rules accordingly) > > I've updated d/compat to 10, but the only related d/rules change I > saw > was dropping --parallel, since it's now default. > > > - please add 2016 to d/copyright for yourself (debian/*) > > Done. > > > Should-Fixes: > > - there is a spelling error lintian complains about (ment -> > > meant). > > Can you check if this is valid and patch it out if so? > > These are false positives (the string "element" is getting > split). Overrides > added. > > > - seems so that github is now leading.. Maybe update the watch file > > to > > follow github? > > I would normally agree, but in this case, the SOCI website still > points > to sourceforge for downloads, so I'm inclined to keep it pointed > there > for now. > > But I'll send an email to the mailing list and see if I can get > someone to > either state that SF will be the home for releases, or that they will > definitely be switching releases to github, in which case, I'll ask > that > they update the link on the homepage. At that point I'll switch the > watch > file and the URL in the d/copyright. > > > Wishlist: > > - maybe ask upsteram to make another release? Seems so that > > upstream > > worked a lot, maybe some fixes would be valuable to have... > > (Needs careful checking to avoid SO-Name breakage, of course) > > There was talk about it on the mailing list in September, but it > sounds > like they're working toward the 4.0 release, and that there may not > be > any more 3.x releases. There's still no published timeline for a > release date > for the next version, but it looks like it will happen eventually. > > > - There are many compiler warnings about unsafe float comparasion, > > maybe upstream fixed this already, but if not this should be filed. > > - can you look into the test suite, results are currently ignored. > > - would be great if you could enable automatic package tests (see > > dep8, > > ci.debian.net) > > I'll add these to my TODO list, but I likely won't get to them for at > least a > few weeks. > > > I've uploaded the updated package to mentors.d.n: > > dget -x https://mentors.debian.net/debian/pool/main/s/soci/soci_3.2.3 > -2.dsc > > > > Best regards, > Bill Uploaded! Many thanks for your contribution! -- tobi
