On Sun, Nov 06, 2016 at 10:52:26PM +0100, Mònica Ramírez Arceda wrote: > I built the package without these changes and builds ok for me. Weird... The > only thing I did is (a part of changing to qt5) is add a patch to use a > different QtOAuth path. I can run it ok, as well. > > I uploaded my changes to git repository: > https://anonscm.debian.org/git/collab-maint/dianara.git > > It's weird I can build it and you don't... Am I doing something wrong? No, you can build it precisely because of your patch. My change was at the QOAuth level, and yours is at the Dianara level. Both work, but the point of the QOAuth "feature file" is that a Qt project just says "use oauth feature", and these paths are irrelevant to that program's configuration.
If Debian had 50 Qt-based programs in the archive using QOAuth, those 50 would probably need patching. By patching QOAuth, you save 50 patches =) I should note that this does not affect Choqok because, AFAIK, it uses cmake, not qmake, and therefore the .prf file is irrelevant for it. BTW, with the latest Qt 5.7.1 and Plasma package updates in Sid, Dianara no longer crashes under Plasma, so all's good \o/ Thanks! -- Development blog: https://jancoding.wordpress.com
