Control: tag -1 pending Chris Lamb <la...@debian.org> (2016-10-15): > Due to the commented-out "set -e; \" line (note the trailing backslash!), > python-pygraphviz FTBFS when /bin/sh is bash. > > Minimal patch attached. However, you should probably uncomment the set > -e bit and drop the leading - so that test failures actually cause a > FTBFS otherwise that's another bug IMHO.
I've decided to go ahead with just the set -e line dropped for the time
being, as inaction on this serious bug report was going to get both
python-{networkx,pygraphviz} removed from testing.
NMU diff attached.
KiBi.
diff -Nru python-pygraphviz-1.3.1/debian/changelog python-pygraphviz-1.3.1/debian/changelog --- python-pygraphviz-1.3.1/debian/changelog 2016-04-23 01:32:13.000000000 +0200 +++ python-pygraphviz-1.3.1/debian/changelog 2016-10-30 03:09:42.000000000 +0100 @@ -1,3 +1,12 @@ +python-pygraphviz (1.3.1-1.1) unstable; urgency=high + + * Non-maintainer upload. + * Remove “set -e; \” line in the dh_auto_test override, which was commented + out already. Test results are ignored entirely anyway. This fixes the + FTBFS with /bin/sh as bash, thanks to Chris Lamb (Closes: #840845). + + -- Cyril Brulebois <k...@debian.org> Sun, 30 Oct 2016 03:09:42 +0100 + python-pygraphviz (1.3.1-1) unstable; urgency=medium [ Sandro Tosi ] diff -Nru python-pygraphviz-1.3.1/debian/rules python-pygraphviz-1.3.1/debian/rules --- python-pygraphviz-1.3.1/debian/rules 2016-04-23 01:32:13.000000000 +0200 +++ python-pygraphviz-1.3.1/debian/rules 2016-10-30 03:04:32.000000000 +0100 @@ -42,7 +42,6 @@ override_dh_auto_test: ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),) - #set -e; \ -for python in $(PYTHON2) $(PYTHON3); do \ echo "-- running tests for "$$python" plain --" ; \ LIB=$$($$python -c "from distutils.command.build import build ; from distutils.core import Distribution ; b = build(Distribution()) ; b.finalize_options() ; print (b.build_platlib)") ; \
signature.asc
Description: Digital signature
