My, my, my... Is not the obvious bug obvious? :)

Well, that this is bad perl is obvious. That it actually does fix
this reported bug isn't so much, but if you try to do

make bin/version.82540em.rom.o

in the src dir you'll find that this script bombs out. Fixing it
gets you a happy fun package (in my case a custom one of latest
git flavours - same code exists in the official package).

--- ipxe-1.0.0+git-20160307.99b5216.orig/src/util/parserom.pl
+++ ipxe-1.0.0+git-20160307.99b5216/src/util/parserom.pl
@@ -157,7 +157,7 @@ sub process_isa_rom {
 
 # Output Makefile rules for the specified ROM declarations
 sub print_make_rules {
-    my ( $state, my $image, my $desc, my $vendor, my $device, my $dup ) = @_;
+    my ( $state, $image, $desc, $vendor, $device, $dup ) = @_;
     unless ( $state->{'is_header_printed'} ) {
         print "# NIC\t\n";
         print "# NIC\tfamily\t$state->{family}\n";

Reply via email to