Thanks for the patches! I think the first patch is straight forward
enough. I'll let Antonio comment on whether he wants to apply the other
two. I just had one comment, inline.
> From 607b2b8f5c12377efe9b81e4bdf8105a3f2a6c0c Mon Sep 17 00:00:00 2001
> From: Guillem Jover <guil...@debian.org>
> Date: Tue, 18 Oct 2016 03:54:21 +0200
> Subject: [PATCH 2/3] debrepro: Use dpkg-buildpackage instead of ad-hoc code
>
> Part of the reproducible machinery is handled already by
> dpkg-buildpackage, so there's no need to duplicate it. We can also
> pass faketime+fakeroot as a normal gain-root-command.
> ---
> scripts/debrepro.sh | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/scripts/debrepro.sh b/scripts/debrepro.sh
> index 38dd14f..0003d22 100755
> --- a/scripts/debrepro.sh
> +++ b/scripts/debrepro.sh
> @@ -56,8 +56,6 @@ create_build_script() {
> echo "# package"
> echo
>
> - echo 'export SOURCE_DATE_EPOCH=$(date -d "$(dpkg-parsechangelog -SDate)"
> +%s)'
> -
> variation PATH
> vary '' 'export PATH="$PATH":/i/capture/the/path'
>
> @@ -83,13 +81,9 @@ create_build_script() {
> echo 'cd ../disorderfs'
> fi
>
> - echo
> - echo 'dpkg-source --before-build .'
> - echo 'fakeroot debian/rules clean'
> -
> variation date
> - vary 'fakeroot debian/rules binary' \
> - 'faketime "+213days +7hours +13minutes" fakeroot debian/rules binary'
> + vary 'dpkg-buildpackage -b' \
> + 'dpkg-buildpackage -b -r"faketime +213days+7hours+13minutes fakeroot"'
Shouldn't these use "-us -uc" too? The intention of debrepro is just to
check for variance, not to produce something to upload, so I don't think
it should default to signing.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
