On Wed, 2016-10-05 at 08:47 +0200, Marc Haber wrote: > On Tue, Oct 04, 2016 at 08:26:53PM +0100, Sam Morris wrote: > > > > BTW, I noticed the newly-shipped cron job. According to sd_booted(3), > > you should test whether systemd was used to boot the system by running > > [ -d /run/systemd/system ] rather than examining /proc/1/exe. This is a > > stable interface that will not change in the future. You can also test > > the exit status of 'systemd-notify --booted'. > > > > Another pattern I have seen used by a couple of packages is to ship a > > .timer and a .service file to perform the regular task, and a > > corresponding cron job that invokes the same command when the system is > > not booted with systemd. For example, see /etc/cron.daily/apt-compat > > and apt-daily.{timer,service}. > > As I am taking upstream's code nearly verbatim with only the minimal > necessary changes to make the paths fit a Debian system, I would only > do that if upstream decides to do so. I would like to suggest that you > either open a new wishlist bug in Debian or - preferred - talk to > upstream yourself. > > Greetings > Marc
No problem--but I'm talking about debian/atop.cron.d; upstream's cron files are not used by the package (the choice between systemd/sysv is made at install time if you're using upstream's own cron jobs). Cheers, -- Sam Morris <https://robots.org.uk/> PGP: rsa4096/CAAA AA1A CA69 A83A 892B 1855 D20B 4202 5CDA 27B9
signature.asc
Description: This is a digitally signed message part