Package: pam
Severity: normal
Tags: patch

Hello!

I experimented with putting pam in CVS and builing
packages and discovered an error in debian/rules:
there is a "rm -f  Linux-PAM/bin/[a-z]*" line.

This works as intended virtualy only in C/POSIX locale,
and in other ones catches filenames that starts with
uppercase too. For example, prior to first clean, there
uses to be a README file in Linux-PAM/bin directory. ;)

But I noticed the bug because I was working with CVS
and there was a Linux-PAM/bin/CVS subdir of course, and
naturally the clean brutally failed (rm: cannot remove
`CVS': Is a directory).

There are 3 possible workarounds:
1. export LC_COLLATE=C; rm -f  Linux-PAM/bin/[a-z]*; unset LC_COLLATE
2. rm -f  Linux-PAM/bin/[abcdefghijklmnopqrstuvwxyz]*
3. rm -f  Linux-PAM/bin/[[:lower:]]*

1st way isn't good if LC_COLLATE is assigned to
something meaningful _prior to clean_ (because it is
brutally unset then)!

I prefer 2nd variant, you may choose 3rd though...

-- 
WBR,
xrgtn

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (501, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i586)
Kernel: Linux 2.4.27-debsec
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Index: debian/rules
===================================================================
RCS file: /var/cvs/deb/pam/debian/rules,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- debian/rules        9 Feb 2005 13:19:17 -0000       1.1
+++ debian/rules        9 Feb 2005 15:21:22 -0000       1.2
@@ -52,7 +52,7 @@
        dh_testroot
        -$(MAKE) -C $(BUILD_TREE) distclean
        rm -f build-stamp configure-stamp
-       rm -f  Linux-PAM/bin/[a-z]*
+       rm -f  Linux-PAM/bin/[abcdefghijklmnopqrstuvwxyz]*
        dh_clean
 
 # Build architecture-independent files here.

Reply via email to