Control: tag -1 + upstream confirmed On Fri, 30 Sep 2016 09:05:48 +0300, Niko Tyni wrote:
> Package: libtext-micromason-perl > Version: 2.19-1 > Severity: important > User: debian-p...@lists.debian.org > Usertags: autopkgtest perl-5.24-transition > > As seen at > https://ci.debian.net/packages/libt/libtext-micromason-perl/unstable/amd64/ > this package fails its autopkgtest checks on current sid. > > The Text::MicroMason::ParseInfo module no longer passes the syntax check. > > # Useless use of push with no values at > /usr/share/perl5/Text/MicroMason/ParseInfo.pm line 37. > # Experimental push on scalar is now forbidden at > /usr/share/perl5/Text/MicroMason/ParseInfo.pm line 37, near "$3 > # }" > # /usr/share/perl5/Text/MicroMason/ParseInfo.pm had compilation errors. I'm not really sure what this code is supposed to do: push $parse_info->{'args'}->{ "$1$2" } = $3 The following patch fixes the syntax error but I don't know if it does what it should, and it seems that the codepath is never tested (otherwise we'd see test failures): --- a/lib/Text/MicroMason/ParseInfo.pm +++ b/lib/Text/MicroMason/ParseInfo.pm @@ -33,7 +33,7 @@ if ( $token_type eq 'args' ) { while ( $token_value =~ /^\s*([\$\@\%])(\w+)(?:\s*=>\s*([^\r\n]+))?/g ) { - push $parse_info->{'args'}->{ "$1$2" } = $3 + push @{ $parse_info->{'args'}->{ "$1$2" } }, $3; } } elsif ( $token_type eq 'file' ) { Forwarding the bug upstream ... Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Tom Waits: Downtown Train
signature.asc
Description: Digital Signature
