retitle 699917 dsc-statistics: Should probably not FTBFS just because of diff 
being big
tags 699917 + patch
thanks

The bug reported by Thorsten is probably fixed, but only in the sense
that the package does not currently FTBFS.

The underlying bug, the "time bomb" in debian/rules, is still there
(and that's why I'm changing the title).

I don't think packages should fail because of diff being big.

A warning message, maybe, but not a total failure.

So I propose the attached patch. It's annoying enough for a human but
it should be completely harmless for an autobuilder.

[ OTOH, if it is really true that the condition in the "if" block really
  makes repackaging absolutely required, then this bug should just be
  closed. ]

Thanks.
--- a/debian/rules
+++ b/debian/rules
@@ -37,8 +37,8 @@ binary-arch:
        pdftotext docsrc/dsc-manual.pdf docsrc/dsc-manual.txt
        pdftotext doc/dsc-manual.pdf doc/dsc-manual.txt
        if [ "$$(wdiff --no-common docsrc/dsc-manual.txt doc/dsc-manual.txt | 
wc -l)" -gt 8 ]; then \
-               echo "too many changes in docs since release, .orig.tar.gz 
repackaging needed"; \
-               exit 1; \
+               echo "too many changes in docs since release, .orig.tar.gz 
repackaging recommended"; \
+               sleep 10; \
        fi
        cp docsrc/dsc-manual.pdf 
$(CURDIR)/debian/dsc-statistics-collector/usr/share/doc/dsc-statistics-collector/dsc-manual.pdf
        dh_install -a

Reply via email to