On 20/09/2016 01:54, Michael Biebl wrote:
Hi


On Tue, 09 Aug 2016 14:00:05 +0200 Landry MINOZA <lmin...@mgi.fr> wrote:
Package: gnome-shell
Version: 3.20.3-1+b1
Severity: normal

--- Please enter the report below this line. ---
When a windowed application hangs, gnome launchs a dialog asking if
user want to force close the application or wait the the application
become available.
This dialog is launched with bad defaults, if one closes it with the
window decoration button or typing [ESC] key, the application is
killed.
It caused me to lose some work a few times when an application is a
little slow to respond and I press [ESC] key to dismiss the force close
dialog. This behavior is very counter intuitive.
Thanks for your bug report. This is an issue which should be addressed
upstream. For that, please file a bug at

https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-shell


Regards,
Michael


Tried to write a little patch (submitted upstream against master and attached), but hard to rebuild all things to test it here.

Are you or any other following this bug able to test it?

--

*Landry MINOZA*
MGI Sud-Ouest/
Chef de projet technique Linux et réseaux/
E-mail : lmin...@mgi.fr <mailto:lmin...@mgi.fr>

        

Tél :01 45 44 54 10

MGI France :11 rue de Téhéran - 75008 Paris | RCS: Paris B 382 770 584 |www.mgi.fr <http://www.mgi.fr> MGI SO :281 route d'Espagne - 31100 Toulouse | RCS: Toulouse B 421 125 816 |www.mgi.fr <http://www.mgi.fr> MGI Suisse :5 avenue de Rothorn - CH3960 Sierre | TVA 517-269 |www.mgiconsultants.ch <http://www.mgiconsultants.ch>

diff --git a/src/core/delete.c b/src/core/delete.c
index 141cd49..936fe83 100644
--- a/src/core/delete.c
+++ b/src/core/delete.c
@@ -45,7 +45,7 @@ dialog_exited (GPid pid, int status, gpointer user_data)
   window->dialog_pid = -1;
 
   /* exit status of 1 means the user pressed "Force Quit" */
-  if (WIFEXITED (status) && WEXITSTATUS (status) == 1)
+  if (WIFEXITED (status) && WEXITSTATUS (status) == 0)
     meta_window_kill (window);
 }
 
@@ -138,7 +138,7 @@ show_delete_dialog (MetaWindow *window,
     meta_show_dialog ("--question",
                       window_content, NULL,
                       window->screen->screen_name,
-                      _("_Wait"), _("_Force Quit"),
+                      _("_Force Quit"), _("_Wait"),
                       "face-sad-symbolic", window->xwindow,
                       NULL, NULL);
 

Reply via email to