Hi Gianfranco, many thanks for reviewing this revised package.
(I'll make sure I use "plain text mode" for gmail from now on) 1. I've completely redone the copyright file - obviously alot of the files Ikey has updated to 2016 (but not all) so this is reflected in the new copyright + a couple of double copyrighters such as Josh Klar. I ran licensecheck as well - where the files where marked as "generated" and did not have a .vala equivalent I have not added these to the copyright. These are by-products of the make distcheck process upstream uses. 2. I re-raised the generated files question here upstream: https://github.com/solus-project/budgie-desktop/issues/588 " I seem to remember we had this conversation before, getting deja vu anyway :) That's how the Vala+autotools stuff works. The only way for me to workaround it is to forcibly delete the stamps, which in turn breaks distcheck. We don't use any conditionals in the Vala code for exactly this reason, we know the .c files aren't being regenerated, so the conditionals would never work (they don't make it to the .c..) We could try to hack the .c's out it, but I think the time would be best spent on rewriting to C for 10.3, as we need to fix all those odd issues (like not being able to have proper relro plugins), then we can just drop all the .vala anyway. I'd like to see what Debian makes of that proposition, because I think we're all a bit sick of Vala in Budgie Desktop by now anyway, right? :)" 3. I've added the libaccountservice-dev to the changelog. I've also rerun check-all-the-things and this looks similar to the results of budgie-desktop-10.2.6 Cheers David On 13 September 2016 at 10:57, Gianfranco Costamagna <locutusofb...@debian.org> wrote: > control: owner -1 ! > control: tags -1 moreinfo > > Hi,(please don't use html in mail, when possible) > > >>budgie-desktop: > > 1) lots of missing copyrights, e.g. > Copyright (C) 2015-2016 Solus Project > > Copyright 2014 Josh Klar <j...@iv597.com> (original Budgie work, prior to > Budgie 10) > > 2) I see a lot of autogenerated files: > > "/* main.c generated by valac 0.32.1, the Vala compiler" > > are you sure you are rebuilding them in Debian builds? > > grep generated . -Ri |grep vala |grep -v "do not" |wc -l > 57 > > 3) added dependency not mentioned in changelog > + libaccountsservice-dev, > > other stuff seems good > > G.
