control: owner -1 ! control: tag -1 +moreinfo Dear Boyuan,
Thanks for this! Before I do a proper review let's talk about the source code/repacking situation. Are there/could there be other libraries that use code generated from the Evernote thrift files? For example, bindings for another language (python, haskell, perl)? If so, the Evernote thrift files should be in their own package, and this package can build-depend on it. That would clean things up a bit, but it wouldn't help with QEverCloudGenerator -- I guess that no packages other than qevercloud itself will use that, right? If it would be easier for you to maintain, you could put QEverCloudGenerator in its own package and build-depend on it, but that's your choice. It looks like you are have removed the files you are going to regenerate from the upstream tarball. That's okay, but you don't have to do it -- you can just delete them before you regenerate them/just overwrite them. See the ebib source package for a very simple example of regenerating a file without removing it from the upstream tarball. Let me know what you think of these suggestions. -- Sean Whitton
