Package: release.debian.org Tags: jessie Followup-For: Bug #836571 User: release.debian....@packages.debian.org Usertags: pu
> *No*. The bug you're fixing may be critical, the request to fix it in > stable is at most normal. Appologies - my misunderstanding. > Given the fact that the package has no reverse-dependencies and before > your NMU in unstable had not been updated for two years, I wonder > whether removal might have been a better option. That's a fair point - but presumably a matter for the PAPT rather than me? > I assume your rationale for suggesting a release via stable-updates, > rather than simply waiting for the next point release (which will be in > just under two weeks time) is the potential for data loss. This may be me misunderstanding the roles of stable-updates and point releases. The next point release sounds fine, particularly given that #817231 had already been open for some time. I've rebuilt the diff with version 0.16-1+deb8u1 as I started from the Jessie source package. Hopefully I have got it right this time? Thanks for your help. Christopher Hoskin
diff -Nru rabbitvcs-0.16/debian/changelog rabbitvcs-0.16/debian/changelog --- rabbitvcs-0.16/debian/changelog 2014-10-05 10:21:39.000000000 +0100 +++ rabbitvcs-0.16/debian/changelog 2016-09-04 18:52:26.000000000 +0100 @@ -1,3 +1,10 @@ +rabbitvcs (0.16-1+deb8u1) jessie; urgency=medium + + * Non-maintainer upload. + * Fix "All files in home folder removed" Applied upstream fix as patch (Closes: #817231) + + -- Christopher Hoskin <christopher.hos...@gmail.com> Sun, 04 Sep 2016 18:52:18 +0100 + rabbitvcs (0.16-1) unstable; urgency=medium * Team upload. diff -Nru rabbitvcs-0.16/debian/patches/fix-817231.patch rabbitvcs-0.16/debian/patches/fix-817231.patch --- rabbitvcs-0.16/debian/patches/fix-817231.patch 1970-01-01 01:00:00.000000000 +0100 +++ rabbitvcs-0.16/debian/patches/fix-817231.patch 2016-09-04 07:05:41.000000000 +0100 @@ -0,0 +1,38 @@ +Subject: Repository Browser export empties target folder + A critical bug, where when the user attempts to export files from within the + RabbitVCS Repository Browser to a local target folder, the contents of the + target folder are deleted without warning, and the export fails. +Origin: upstream, https://github.com/rabbitvcs/rabbitvcs/pull/89/commits/b3dc98601d57d2e589999e491a66b562a399ce1a +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817231 +Bug: https://github.com/rabbitvcs/rabbitvcs/issues/70 +Bug: https://github.com/rabbitvcs/rabbitvcs/issues/127 +Bug: https://github.com/rabbitvcs/rabbitvcs/issues/161 +From: abaheti <abah...@tibco.com> +Acked-by: Christopher Hoskin <christopher.hos...@gmail.com> +Last-Update: 2016-08-28 +Applied-Upstream: commit:b3dc986, https://github.com/rabbitvcs/rabbitvcs/pull/89/commits/b3dc98601d57d2e589999e491a66b562a399ce1a + +--- + rabbitvcs/vcs/svn/__init__.py | 6 +----- + 1 file changed, 1 insertion(+), 5 deletions(-) + +diff --git a/rabbitvcs/vcs/svn/__init__.py b/rabbitvcs/vcs/svn/__init__.py +index 96d821d..dee5e7f 100644 +--- a/rabbitvcs/vcs/svn/__init__.py ++++ b/rabbitvcs/vcs/svn/__init__.py +@@ -1237,11 +1237,7 @@ class SVN: + @param recurse: Whether or not to run a recursive checkout. + + """ +- if os.path.exists(dest_path): +- if os.path.isdir(dest_path): +- shutil.rmtree(dest_path) +- else: +- os.remove(dest_path) ++ revision=Revision("head") + + + +-- +2.9.3 + diff -Nru rabbitvcs-0.16/debian/patches/series rabbitvcs-0.16/debian/patches/series --- rabbitvcs-0.16/debian/patches/series 2014-10-05 10:12:07.000000000 +0100 +++ rabbitvcs-0.16/debian/patches/series 2016-09-04 07:05:41.000000000 +0100 @@ -1 +1,2 @@ 99_setup.py.patch +fix-817231.patch