Control: tags -1 + confirmed Control: severity -1 important On 08/30/2016 10:05 PM, Frank Fegert wrote: > probably just an odd corner case, but it seems that umountiscsi.sh > indiscriminately tries to umount *all* LVM based filesystems - even > those on local disks - when no iSCSI sessions are found by the code > in function "enumerate_iscsi_devices()". I've tried to explain the > experienced issue in greater detail here: > http://www.bityard.org/blog/2016/08/28/backporting_open-iscsi_debian_jessie
Yeah, that's not intended. Thanks for catching this! > A quick'n'dirty solution which worked for me can be found here: > > https://github.com/frank-fegert/debian_open-iscsi/commit/5118af7fb23ed90281c7a5db3fde0e09bc61b225 > > Can you please take a look at this and possibly confirm this issue? While not having tested this, from just looking at the code with your explanation in mind, yes, you're right about that. Your fix is also correct, but I'm not sure I like the endless list of -o -n repeats... I'll think about it for a while and if I can't find a better solution, I'll commit your fix to git. (And if I find a better solution, I'll commit that. ;-)) I'll let the current version migrate to testing first before another upload though, because I want to get iscsiuio into testing first. Speaking of: you appear to be interested in a backport of open-iscsi into Jessie because you want to use offloading via iscsiuio. I've been thinking about uploading open-isns and open-iscsi to jessie-backports myself (precisely to have iscsiuio support available for Jessie users), but was unsure whether there's enough people who'd be interested in that. Would that be something you'd use yourself? Or would you want to continue to use your special backported version instead? Since you're actively using iscsiuio, I'd like to hear your opinion on that first. Regards, Christian
