Package: phpgacl
Severity: minor
Tags: patch

Hi,

Here is a commented patch to fix your Debconf templates.
Please follow the developers-reference when writing such templates (see
http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s6.5).

####################
-_Description: Please enter the name of the database to use
+_Description: Name of the database:
 
-_Description: Please enter the hostname of the database server to use
+_Description: Hostname of the database server:
 
-_Description: Please enter the name of the database user you want to use
+_Description: Name of the database user:
 
-_Description: Please enter the password for the database connection
+_Description: Password for the database connection:
#####################

see #s6.5.4.2.1 and #s6.5.4.2.3


#####################
-_Description: Automatically configure apache for phpGACL?
+_Description: Version(s) of Apache to configure automatically:
#####################

This question would have been correct for a "boolean" template, but here
it is a "select"; see #s6.5.4.2.3
The word "Version" is only a suggestion.


#####################
- dropping a symlink into the /etc/APACHE-SERVER/conf.d directory. Would you
- like me to do this? Say no if you aren't running apache or you would
- prefer to set up the web server yourself. If you say yes here, all
- configuration changes will also be removed when the packages is purged.
+ dropping a symlink into the /etc/APACHE-SERVER/conf.d directory.
+ Select "None" if you aren't running apache or you would
+ prefer to set up the web server yourself. If you select a version to 
configure, all
+ configuration changes will also be removed when the package is purged.
#####################

* The sentence "Would you like me to do this?" is pointless, and is using
  the first person (see #s6.5.2.5)
* There is no "no" or "yes", it is a "select" template (and you should
  not make assumptions about interfaces if this was a "boolean"
  template, see #s6.5.2.4).
* typo


#####################
-_Description: This system uses an obsolete configuration file.
+_Description: Obsolete configuration file
#####################

The short description should be considered to be a title (see
#s6.5.4.2.4)


#####################
- (/etc/phpgacl/gacl.ini.php) and remove the obsolote one.
+ (/etc/phpgacl/gacl.ini.php) and remove the obsolete one.
#####################

typo

Full patch attached.

Cheers,


-- 
Thomas Huriaux
--- phpgacl.templates.orig      2006-01-21 16:37:05.000000000 +0100
+++ phpgacl.templates   2006-01-21 16:50:15.000000000 +0100
@@ -1,35 +1,35 @@
 Template: phpgacl/name
 Type: string
 Default: phpgacl
-_Description: Please enter the name of the database to use
+_Description: Name of the database:
 
 Template: phpgacl/host
 Type: string
 Default: localhost
-_Description: Please enter the hostname of the database server to use
+_Description: Hostname of the database server:
 
 Template: phpgacl/user
 Type: string
 Default: root
-_Description: Please enter the name of the database user you want to use
+_Description: Name of the database user:
 
 Template: phpgacl/pass
 Type: password
 Default: 
-_Description: Please enter the password for the database connection
+_Description: Password for the database connection:
 
 Template: phpgacl/apache
 Type: select
 _Choices: Apache, Apache2, Apache-SSL, Both, All, None
-_Description: Automatically configure apache for phpGACL?
+_Description: Version(s) of Apache to configure automatically:
  phpGACL requires a few things to be set up in your web server
  configuration in order for the front end to function properly.
  .
  The Debian packaged version can usually automatically configure apache by
- dropping a symlink into the /etc/APACHE-SERVER/conf.d directory. Would you
- like me to do this? Say no if you aren't running apache or you would
- prefer to set up the web server yourself. If you say yes here, all
- configuration changes will also be removed when the packages is purged.
+ dropping a symlink into the /etc/APACHE-SERVER/conf.d directory.
+ Select "None" if you aren't running apache or you would
+ prefer to set up the web server yourself. If you select a version to 
configure, all
+ configuration changes will also be removed when the package is purged.
  .
  Since there is no special Apache2-SSL, 'both' means Apache and Apache-SSL.
 
@@ -39,7 +39,7 @@
 
 Template: phpgacl/conffile_changed
 Type: note
-_Description: This system uses an obsolete configuration file.
+_Description: Obsolete configuration file
  Your system has an obsolete configuration file
  (/etc/phpgacl/phpgacl.conf.php). Please, review the new configuration file
- (/etc/phpgacl/gacl.ini.php) and remove the obsolote one.
+ (/etc/phpgacl/gacl.ini.php) and remove the obsolete one.

Attachment: signature.asc
Description: Digital signature

Reply via email to