On 4 August 2016 at 17:48, Gianfranco Costamagna
<locutusofb...@debian.org> wrote:
> so please enforce the version and go for experimental, how do you expect to
> be able to build it in unstable with experimental toolchain?
On my jessie the `luajit 2.0` works with `lua-torch-torch7` in some cases,
however this will be troublesome when running unit tests.
I'll change the target release, and make the B-D luajit version
constraint strict.
> also, not needed to specify this
> Depends: ${misc:Depends}, ${shlibs:Depends}, luajit | lua5.1,
>
>
>
> for the -dev package, because already specified in the library itself.
OK, I will fix this.
> +SET_TARGET_PROPERTIES(luaT PROPERTIES
> + VERSION 0
> + SOVERSION 0)
>
>
> do you really want to maintain that downstream? please forward it.
OK.
> why luaT and TH are not packaged separately? at a first look (not careful at
> all)
> they look external dependencies
Actually there are separated:
libtorch-th{,-dev} -> libTH.so
libtorch-luat{,-dev} -> libluaT.so
I avoided the libth{,-dev} libluat{,-dev} name scheme because I don't want to
pollute the lib* namespace, since they are for specific usage. Hence I created
package for them in the libtorch* scheme.
> also, from check-all-the-things:
> $ codespell --quiet-level=3
WOW so cool the tool is!
> it's all for now
> (I'll continue when I get a building package)
>
>
> G.
Will ping back when ready.
Thanks for reviewing!
--
Best,
Lumin
