control: owner -1 !
control: tags -1 moreinfo

>ITYM 5.7.


Indeed, please fix.

since I reported the upstream issues, and did a lot of work on gammaray, I'll 
sponsor the
package.

Review:

1)

Vcs-Git: https://anonscm.debian.org/pkg-kde/kde-extras/gammaray.git
Vcs-Browser: 
https://anonscm.debian.org/gitweb/?p=pkg-kde/kde-extras/gammaray.git

they seem both wrong, please fix (the second one needs /cgit/, the first /git/)

2) I don't like disabling tests, but you are right on this, since the bug is in 
qt :(

3) missing copyrights:
+  Copyright (C) 2015-2016 Klarälvdalens Datakonsult AB, a KDAB Group company, 
i...@kdab.com
+  Author: Volker Krause <volker.kra...@kdab.com>
+


bad copyright years (many needs bump)

gammaray-2.5.0/cmake/ECMQueryQmake.cmake
gammaray-2.5.0/cmake/QtInstallPaths.cmakegammaray-2.5.0/cmake/lots*.cmake
^^ missing licenses


+    Licensees holding valid commercial KDAB GammaRay licenses may use this 
file in
+    accordance with GammaRay Commercial License Agreement provided with the 
Software.
+
+    Contact i...@kdab.com if any conditions of this licensing are not clear to 
you.
+
+    This work is also licensed under the Creative Commons 
Attribution-ShareAlike 4.0
+    International License. See 
<http://creativecommons.org/licenses/by-sa/4.0/>.
+*/

^^ lots of missing


4) 
http://debomatic-amd64.debian.net/distribution#unstable/gammaray/2.5.0-1/lintian


lots of them can be easily fixed


other stuff LGTM,
I tested both amd64 and i386 with success.

thanks,

G.

Reply via email to