Package: nm.debian.org
Severity: minor
Tags: patch
Hello,
Although rows are clickable in the auto expanding mail table, the cursor
is not a pointer.
It appears that the functionallity exists (there is a tr.clickable CSS
class) but the clickable class is by mistake assigned to the table
instead of the tr elements.
The attached patch should fix the issue.
>From 06c240a6aa39a03589ec031cf965bda7908b0fd3 Mon Sep 17 00:00:00 2001
From: Christos Trochalakis <yati...@ideopolis.gr>
Date: Wed, 20 Jul 2016 15:50:28 +0300
Subject: [PATCH] Fix clickable table row cursor
Although rows are clickable in the auto expanding mail table the cursor
is not a pointer.
It appears that the functionallity exists (there is a tr.clickable CSS
class) but the clickable class is by mistake assigned to the table
instead of the tr elements.
While we are at it, we can clarify the mailstable.find() expression a
bit.
---
process/templates/process/display-mail-archive.html | 6 +++---
restricted/templates/restricted/display-mail-archive.html | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/process/templates/process/display-mail-archive.html b/process/templates/process/display-mail-archive.html
index 0fe2b1b..4801b10 100644
--- a/process/templates/process/display-mail-archive.html
+++ b/process/templates/process/display-mail-archive.html
@@ -25,7 +25,7 @@ $(function() {
},
});
- mailstable.find("tbody").find("tr").click(function(ev) {
+ mailstable.find("tr.clickable").click(function(ev) {
var el = $(this);
el.next(".showable").toggle();
});
@@ -42,7 +42,7 @@ $(function() {
(Click to see the message body)
-<table id="mailstable" class="tablesorter {{class}}">
+<table id="mailstable" class="tablesorter">
<thead>
<tr>
<th>Date</th>
@@ -52,7 +52,7 @@ $(function() {
</thead>
<tbody>
{% for m in mails %}
- <tr>
+ <tr class="{{class}}">
<td>{{m.Date}}</td>
<td>{{m.From}}</td>
<td>{{m.Subject}}</td>
diff --git a/restricted/templates/restricted/display-mail-archive.html b/restricted/templates/restricted/display-mail-archive.html
index 0fe2b1b..4801b10 100644
--- a/restricted/templates/restricted/display-mail-archive.html
+++ b/restricted/templates/restricted/display-mail-archive.html
@@ -25,7 +25,7 @@ $(function() {
},
});
- mailstable.find("tbody").find("tr").click(function(ev) {
+ mailstable.find("tr.clickable").click(function(ev) {
var el = $(this);
el.next(".showable").toggle();
});
@@ -42,7 +42,7 @@ $(function() {
(Click to see the message body)
-<table id="mailstable" class="tablesorter {{class}}">
+<table id="mailstable" class="tablesorter">
<thead>
<tr>
<th>Date</th>
@@ -52,7 +52,7 @@ $(function() {
</thead>
<tbody>
{% for m in mails %}
- <tr>
+ <tr class="{{class}}">
<td>{{m.Date}}</td>
<td>{{m.From}}</td>
<td>{{m.Subject}}</td>
--
2.8.1
