On 15.07.2016 [17:48:08 +0200], Carsten Leonhardt wrote:
> tags 830999 + confirmed patch
> thanks
>
> Dear Nish,
>
> > That seems very right to me, I will try and test it here too.
> >
> > update_mysql_tables.in
> > update_mysql_tables_10_to_11.in
> > update_mysql_tables_11_to_12.in
> >
> > may need similar changes (they did in 7.4.1+dfsg-1, and I haven't
> > rebased yet to check if they still apply).
>
> I've committed a different fix to git now which doesn't need to touch
> all these files.
Great, thanks!
> > Also, depending on the source, you may want to ensure that
> > update_mysql_tables.in's db_name assignemnt properly uses the
> > ${db_name:-@db_name@} so that environment variables can be used with it.
>
> You mean for people not using dbconfig-common?
Yeah, iirc, the scripts end up living in /usr/share/bacula-director/ and
are sometimes referenced online as a way to manually do migrations, etc.
I believe upstream has made the referenced changed already, in a bugfix:
http://www.bacula.org/git/cgit.cgi/bacula/commit/?h=Branch-7.4&id=074419ac0c9dbbde2e4d2f5ccb6d4ca85c6ec8a9
