Le 06/07/16 à 22:12, Helge Kreutzmann a écrit :
Hello Laurent,
Hello Helge,
thanks for the information; however, I consider this upload hostile.
Fixing a severity normal bug without prior anouncement for the NMU and
not using a delay queue is IMHO not proper usage of your rights (even
though I'm "only" debian maintainer and this is low NMU).
I'm sorry that you are taking it like that, but the
https://wiki.debian.org/LowThresholdNmu page explicitly states:
"The maintainers and maintainer groups listed below declare that their
packages (all, or the ones listed specifically below) may be fixed and
uploaded without delay, at any time, as long as the NMU procedure in the
Debian Developer's Reference is otherwise followed. You don't need to
contact the maintainers beforehand, and you don't need to use a delayed
upload queue. If the package maintainer or maintainer group is active,
it is polite to let them have a stab at fixing the problem first."
I think that the process has been respected here.
Further you state:
> Indeed, booth packages contain the same files, adwaita theme is the
> new one provided by the gnome project. gnome-icon-theme has been
> deprecated for quite some times.
However, as stated neither package confirms your statement. It might
be obvious to you but for me it isn't. Thus I intended to research the
issue further which I did not have time to do.
As I said in a previous mail, the default gtk+3.0 icon theme is Adwaita:
https://sources.debian.net/src/gtk%2B3.0/3.20.6-2/gtk/gtksettingsprivate.h/#L27
goobox uses the following icons, they all exist in Adwaita icon theme
except the RTL ones that are called differently (because they are not
part of the xdg standard but a GNOME extension apparently and GNOME
decided to change their naming convention from "*-rtl-symbolic" to
"*-symbolic-rtl"):
src/gtk-utils.h:#define GOO_ICON_NAME_PLAY "media-playback-start-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_PLAY_RTL
"media-playback-start-rtl-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_PAUSE "media-playback-pause-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_STOP "media-playback-stop-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_NEXT "media-skip-forward-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_NEXT_RTL
"media-skip-forward-rtl-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_PREV "media-skip-backward-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_PREV_RTL
"media-skip-backward-rtl-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_EJECT "media-eject-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_EXTRACT "document-save-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_RESET "goo-reset"
src/gtk-utils.h:#define GOO_ICON_NAME_NO_DISC "media-optical-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_DATA_DISC "drive-harddisk-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_AUDIO_CD "media-optical-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_VOLUME_MAX
"audio-volume-high-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_VOLUME_MED
"audio-volume-medium-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_VOLUME_MIN "audio-volume-low-symbolic"
src/gtk-utils.h:#define GOO_ICON_NAME_VOLUME_ZERO
"audio-volume-muted-symbolic"
Asking on #gnome-hackers, I've been told that since version 3.13.2, GTK
itself loads the RTL icons using the correct names. So the patch I've
added (removing special handling of RTL icons) is part of my original
bug and has been tested with RTL locales.
I usually try to fix important bugs as fast as possible but your bug
(severity normal) report at no time indicated any urgency. (And btw I
had a machine crash some weeks ago and I'm just restored on a new
machine from backups, thus delaying work on non-urgent matters also).
Furthermore you add a patch which has not been proposed in the bug
report system in your NMU. Is there any reason you did not send it as
(severity ... bug) into the bts? I find this rather strange (to
phrase it simply) that it was added as "add on" in your NMU. Further
looking at the report in the upstream BTS I see that it was proposed
at severity "normal" on 2016-07-05 15:26, about *2 hours* before the
upload. Without any review by the upstream maintainer (nor any other
bug activity, for that matter).
I'm rather disappointed about this behaviour.
I set lownmu in case I'm on vacation and goobox FTBS for some
toolchaine issue or the freeze occurs and some (reported!) bug needs
urgent fixing but not for normal and "just reported upstream issues"
(again normal severity) to be simply fixed in an NMU.
I'm limited on time right now, but will discuss this with upstream and
then later decide how to proceed in this matter. Especially since your
change *completely* drops any icon them from package relationships,
quite the oppsite as requested in #678223 (although we discussed this
in the BTS).
IMHO (and I'm working on this as part of my work in the GNOME team),
it's not the business of individual packages to have a dependency
against a theme. The themes should either be pulled from a meta package
or some other packages higher in the dependency chain. Otherwise it
would be difficult for a end user (or a downstream distribution) to
change the default theme without modifying 10th of packages. Also, with
GTK3, the icons from the "gnome" themes are not used at all as explained
above (or only as a fallback).
Kind regards,
Laurent Bigonville
Just as sidenotes your patch does not update debian/copyright and
introduces a new naming convention for patches, if that matters.
Not amused at all
Helge
