Raphael Hertzog wrote: > So I would also love to see it merged sooner rather than later.
I've had a look at this and made a couple of improvements (see below). Can someone please check and then merge from the "send-mails-to-signer-796784" branch of https://github.com/lamby/dak? commit 3de2d3e44e15686a8f7208348becddbc71945f7d Author: Raphal Hertzog <hert...@debian.org> Date: Tue Dec 1 16:20:22 2015 +0100 Implement DInstall::UploadMailRecipients to control recipients of upload mails This new setting lets you configure the list of recipients of upload mails (Accepted/Rejected), you can mix harcoded emails and the special keywords "maintainer", "changed_by" and "signer" which get replaced by the corresponding address extracted from the upload data. The goal is that the security archive only sends mails to the security team and to the person who signed the upload to not leak any information about embargoed uploads. Closes: #796784 config/debian-security/dak.conf | 5 ++++- daklib/utils.py | 47 +++++++++++++++++++++++++++++++++++------ 2 files changed, 44 insertions(+), 8 deletions(-) commit ec0fba847231cff1cb8bab2a622dcad3039c1ee7 Author: Chris Lamb <la...@debian.org> Date: Tue Jul 12 09:53:11 2016 +0200 Add trailing comma to reduce diff noise. daklib/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0c876f44bbda72b9c1b5e2a36077266db6692c54 Author: Chris Lamb <la...@debian.org> Date: Tue Jul 12 09:53:54 2016 +0200 Drop unnecessary list comprehension. daklib/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d3cc6d3e56ef4b9bf3025f825c52133659405755 Author: Chris Lamb <la...@debian.org> Date: Tue Jul 12 09:55:33 2016 +0200 No need to check len(..) daklib/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c8eb37c4f2e14f126d64690d0cccf1c34889b56c Author: Chris Lamb <la...@debian.org> Date: Tue Jul 12 09:57:09 2016 +0200 Clarify what this set is for. daklib/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a5347eab599f1b6119c516ad5cb20bdcc5ccd7de Author: Chris Lamb <la...@debian.org> Date: Tue Jul 12 10:00:13 2016 +0200 Avoid clumsy index/pop with "remove", daklib/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
