* Pali Rohár <pali.ro...@gmail.com>, 2016-07-05, 14:28:
debian/copyright says that the package "was downloaded from
ftp://ftp.gnu.org/gnu/aspell/dict/sk/";, but there is no 2.02-0 at this
location.
I mentioned this because it's a serious violation of Policy §12.5: “the
copyright file must say where the upstream sources (if any) were
obtained”.
Official website for aspell-sk is http://www.sk-spell.sk.cx/aspell-sk
where is also last version. On gnu.org is not last version and upstream
maintainer confirmed it.
Then please update the copyright file.
BTW, what's the difference between 2.01-2 and 2.02-0? There's no entry
for the latter version in doc/CHANGELOG. :-\
There is small changelog entry at website, that dictionary was updated
to Firefox/Thunderbird version.
Quick look at diff between those two versions confirm it. Dictionary is
updated (new words + some fixes).
OK. Please remind upstream that they should keep their changelog up to
date. :)
Also, the copyright file says that the package is under GPL, whereas
this new version is tri-licensed: LGPLv2.1, GPLv2, MPLv1.1.
Ok, I can update debian/copyright file.
Please do.
* Add Homepage and update Standards-Version.
Why are these two in a single item? They seem unrelated to me.
Those were changes in (one) control file, so I added them to one line.
Did you need to do any packaging changes to update S-V?
I wouldn't recommend updating S-V in an NMU.
Well, Debian has in archives very old (maybe prehistoric) version of
aspell-sk package. I reported this problem in bug 603719 in past *six*
years ago and everybody in Debian ignored it, current maintainer too.
And now when I saw that aspell-sk package is going to be removed from
Debian, I updated compat level and thought that bringing new version
should be done too...
There are over 150 different things that changed in Policy since 3.6.2.
I don't feel like going through all of them to verify that the package
does in fact meet all the new requirements. I'm also surprised that any
NMUer would want to go trough this effort, instead of letting the
maintainer do it later.[*]
Addition of debian/watch is not documented in the changelog.
I can add it.
Please do.
You changed source format to "3.0 (quilt)", but this change is not
documented either. Also, changing source format is not suitable for an
NMU, unless you have a very good reason.
I thought that "3.0 (quilt)" format is preferred for new packages,
It's not a new package. :) And I don't know what are the maintainer's
preferences.[*]
[*] In general, please keep NMUs lean. Fix the bugs that bother you;
leave everything else as is.
--
Jakub Wilk
