On 05.07.2016 15:09, Jonas Smedegaard wrote:
Quoting Sandro Mani (2016-07-05 14:15:26)
On 05.07.2016 12:56, Jonas Smedegaard wrote:
Thanks for elaborating on how Fedora uses licensecheck for quality
assurance. I appreciate your contacting upstreams to ensure that
licensing statements are unambiguous and embedded in each file where
copyright is claimed. But instead of suggesting upstreams to
conform to the more strict principle of putting licensing statements
at the top of each file, I recommend that instead Fedora considers
adjusting its quality assureance process to scan whole files instead
of only the header.
Well, I suppose it is licensecheck itself which only scans the
headers?
It is not a Fedora policy of any sort to only scan the headers of the
files, but we are actually relying on the licensecheck script to
detect the license of the various files in the source tarball. And in
this particular case:
$ licensecheck App-Licensecheck-v3.0.1/bin/licensecheck
App-Licensecheck-v3.0.1/lib/App/Licensecheck.pm
App-Licensecheck-v3.0.1/bin/licensecheck: UNKNOWN
App-Licensecheck-v3.0.1/lib/App/Licensecheck.pm: UNKNOWN
(But I don't want to be annyoing or anything, just following our
guidelines ;) )
You are not annoying, not at all!
If you do "licensecheck --help" you will see that there are options to
either check the whole file (--lines 0) or bottom in addition to top
(--tail N).
I recommend to scan the whole file.
Hmm,
$ licensecheck -r --lines 0 App-Licensecheck-v3.0.1
App-Licensecheck-v3.0.1/bin/licensecheck: UNKNOWN
App-Licensecheck-v3.0.1/lib/App/Licensecheck.pm: UNKNOWN
[...]
