Package: tidy-html5
Version: 1:5.2.0-1.1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch

Hi Daniel,

With php7.0 now updated to use tidy-html5 in Ubuntu, I've noticed that
libtidy-dev is pulling in a new dependency on libdmalloc-dev.

A close inspection shows that dmalloc is not actually a requirement of
libtidy-dev; the dmalloc header is included only if one explicitly #defines
DMALLOC in the calling code.  libtidy is certainly not linking to / using
dmalloc's implementation at build time.

So to avoid this unnecessary dependency, I've applied the following patch to
drop the Depends: on libdmalloc-dev to a Suggests:.  But it's possible that
this package relationship should be dropped altogether.

Either way, it's better to not have a dependency that isn't needed, so for
the Ubuntu case, we have patched this to avoid pulling dmalloc into Ubuntu
main unnecessarily.

Thanks for considering this patch!

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru tidy-html5-5.2.0/debian/control tidy-html5-5.2.0/debian/control
--- tidy-html5-5.2.0/debian/control	2016-06-28 06:37:12.000000000 -0700
+++ tidy-html5-5.2.0/debian/control	2016-06-30 18:24:59.000000000 -0700
@@ -49,7 +49,8 @@
 Package: libtidy-dev
 Section: libdevel
 Architecture: any
-Depends: libtidy5 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends}, libdmalloc-dev
+Depends: libtidy5 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends}
+Suggests: libdmalloc-dev
 Breaks: libtidy-0.99-0
 Replaces: libtidy-0.99-0 
 Description: HTML syntax checker and reformatter - development

Reply via email to