On Wed, Jun 29, 2016 at 05:52:32PM +0200, Matthijs Kooijman wrote: > Hi Reiner, > > > While working on the "reproducible builds" effort [1], we have noticed > > that openttd could not be built reproducibly. > > A list of source files is sorted without considering locales, so it > > will be different under differing locales. > Right. Together with upstream we previously fixed some similar issues, > but AFAIU it's not so easy to check the reproducibility of builds > manually. > > > The attached patch fixes this. > Thanks for that, I'll forward it upstream. > > Could you confirm the build becomes reproducible with this patch, or > could more turn up after applying this one?
I have confirmed it with our prebuilder script [1], which does most of the variations that are also run on jenkins (tests.reproducible-buids.org). With the current variations we do there it is reproducible. The diff on jenkins also hints at a locale sorting variation: > - 387: 0000000000000000 0 FILE LOCAL DEFAULT ABS autoreplace.cpp > - 391: 0000000000000000 0 FILE LOCAL DEFAULT ABS > autoreplace_cmd.cpp > + 387: 0000000000000000 0 FILE LOCAL DEFAULT ABS > autoreplace_cmd.cpp > + 397: 0000000000000000 0 FILE LOCAL DEFAULT ABS autoreplace.cpp Kind regards, Reiner [1]: https://anonscm.debian.org/cgit/reproducible/misc.git/tree/prebuilder
signature.asc
Description: Digital signature
