On Wed, Jun 22, 2016 at 10:27:19PM +0200, Nicolas LE CAM wrote: > Package: apt > Version: 1.2.13 > Severity: normal > Tags: patch > > Dear Maintainer, > > The rationnal for this is to be able to disable this "feature" without > modifying package's script. My laptop has a pretty descent battery and > I prefer to keep automatic updates rather than saving a hundreth > percent of power. Actually this feature is hardcoded deep down in the > script without any configuration possibility, by using systemd > feature, I'll be able to disable this behaviour with a simple > /etc/systemd/system/apt-daily.service.d/some.conf file. > > I've made the compatibility cron job functionally equivalent (without > any configuration possibility unfortunately).
The commit short description is a bit too long, can you shorten that to about 70 characters? I'm not sure why the cron job does the check 2 times, I'll have to check that. Apart from that: lgtm. > > The first patch is a nit-pick I saw while hacking apt scripts. > Actually the apt.systemd.daily script (or apt.apt-compat.cron.daily > with my patch) is using the on_ac_power utility without recommending > powermgmt-base, not sure it's useful. Maybe a Suggests instead, especially once we applied 2. (better switch those around then) -- Debian Developer - deb.li/jak | jak-linux.org - free software dev When replying, only quote what is necessary, and write each reply directly below the part(s) it pertains to (`inline'). Thank you.
