Control: tags -1 - moreinfo Hi Andrey,
Thanks for the review. Comments below. On Sunday, June 19 2016, Andrey Rahmatullin wrote: > The package generates quite a lot of lintian output: > > P: newlisp source: source-contains-prebuilt-java-object > guiserver/guiserver.jar This file is generated by guiserver/Makefile. It is a jar file created From the .java files under guiserver/java. > P: newlisp source: source-contains-prebuilt-windows-binary > qa-specific-tests/ffitest.dylib This is a test file. TBH I am not completely sure about what to do with it; there doesn't seem to be a source code available for this file (although it was written by a contributor), and apparently it could be removed (and some tests could be adjusted) without impacting Debian. Or we could just ignore it. > I: newlisp source: vcs-field-uses-insecure-uri vcs-browser > http://git.sergiodj.net/?p=debian/newlisp.git;a=summary > I: newlisp source: vcs-field-uses-insecure-uri vcs-git > git://git.sergiodj.net/debian/newlisp.git These two are temporary. I don't have a repository on alioth to push the code, and I don't use https on my server. I'll replace them as soon as I set up a repo on alioth. > P: newlisp source: debian-watch-may-check-gpg-signature Upstream unfortunately does not provide a GPG signature for the package. I will get in touch with them and request that they make one available. > I: newlisp: spelling-error-in-manpage usr/share/man/man1/newlisp.1.gz Excute > Execute > I: newlisp: spelling-error-in-manpage usr/share/man/man1/newlisp.1.gz Excute > Execute > I: newlisp: spelling-error-in-manpage usr/share/man/man1/newlispdoc.1.gz > documetation documentation Somehow I thought that these were not worth fixing with local patches, but hey, it doesn't hurt. They're fixed now. > W: newlisp: unusual-interpreter usr/bin/newlispdoc #!newlisp > W: newlisp: unusual-interpreter usr/share/newlisp/util/syntax.cgi #!newlisp > > Out of these, the unusual-interpreter tags are blockers as I don't know > how such shebangs could work. The shebangs are right in the original files. They are: #!/usr/bin/env newlisp I guess lintian evaluates this expression somehow and displays the wrong shebang in the warnings. Also, I intend to contact the lintian maintainers as soon as the package is uploaded so that they can add newlisp to the list of known interpreters. > Please don't use manual -dbg subpackage creation as nowadays Debian > creates -dbgsym subpackages automatically. Done. I had forgotten about the -dbgsym, thanks. > debian/newlisp-docs.docs looks like a dh_make cruft, please remove it. Ops, you're right. Removed. > You don't seem to need buildflags.mk and DPKG_EXPORT_BUILDFLAGS as you use > dh_auto_build. Removed, thanks. I have rebuilt the package with the fixes and re-uploaded it to mentors. Thanks for the help! -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
signature.asc
Description: PGP signature
